wtclient: ability to mark a session as borked #7545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
markSessionBorked
branch
2 times, most recently
from
3367a87
to
76bcac9
Compare
ellemouton
force-pushed
the
markSessionBorked
branch
from
76bcac9
to
06f25be
Compare
ellemouton
force-pushed
the
markSessionBorked
branch
from
06f25be
to
13e69ba
Compare
ellemouton
force-pushed
the
markSessionBorked
branch
3 times, most recently
from
8aa895c
to
b655093
Compare
ellemouton
force-pushed
the
markSessionBorked
branch
from
b655093
to
c8ff4dc
Compare
ellemouton
force-pushed
the
markSessionBorked
branch
from
c8ff4dc
to
89ff6fd
Compare
This commit adds a test that demonstrates that a client is unable to continue backing up states to the server if any session errors occur. This will be addressed/fixed in the upcoming commits.
Let the StopAndRemove method return false if a session with the given ID was not found in the queue set. This will be used in an upcoming commit.
A new CSessionBorked status is to represent a session that is should be seen as permanently inactive. Various methods are also updated: - The isSessionClosable methods are updated so that sessions need to be either exhausted _or_ borked in order to considered closable. - The ExhaustedSessionFilter function is also updated to filter out borked sessions. - The markSessionStatus method is updated to make sure that a session marked as borked cannot be marked as inactive or active.
In preparation for the use of this variable in other packages, it is exported in this commit.
Add a new MarkSessionBorked method to the wtclient DB and add a test to assert the behaviour.
This commit adds a Stopped method to the sessionQueue which returns a channel that can be listened on for a signal that the queue has stopped its operations. This tells the backupDispatcher that it should pick or negotiate a new active session queue.
This commit adds the MarkSessionBorked method to the TowerClient and then demonstrate in a test that this method allows a user to force the abort of an erroring session so that a new one can be negotiated.
ellemouton
force-pushed
the
markSessionBorked
branch
from
89ff6fd
to
e923f6b
Compare
This was referenced Nov 30, 2023
|
replaced by: #8239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, watchtower clients now have the ability to force a session to be
marked as "borked". This means that if the server ever returns session errors
that cause updates to not be backed up (like in #6397), the a user can force
the session to be aborted.