macaroons: ensure all root keys are re-encrypted or regenerated #7705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
macStoreRootKeyReEncyption
branch
from
dd0bbb2
to
c8a47d7
Compare
ellemouton
force-pushed
the
macStoreRootKeyReEncyption
branch
2 times, most recently
from
dc32ad8
to
d1e5fa0
Compare
guggero
reviewed
May 17, 2023
This commit adds to the existing TestStoreGenerateNewRootKey to show that the method only successfully regenerates the root key in the default root key ID location. This will be fixed in an upcoming commit.
With this commit, GenerateNewRootKey will regenerate the Default root key and will then also check if any other root keys exist and regenerate those as well.
ellemouton
force-pushed
the
macStoreRootKeyReEncyption
branch
from
d1e5fa0
to
1e1e0ae
Compare
This commits uses TestStoreChangePassword to demonstrate that currently the ChangePassword function only changes the password of the default root key and not that of other root keys. This will be fixed in an upcoming commit.
The ChangePasswords method should re-encrypt all the root keys found in the store, not just the default root key.
ellemouton
force-pushed
the
macStoreRootKeyReEncyption
branch
from
1e1e0ae
to
0787cb1
Compare
This was referenced May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the macaroon store
ChangePasswordmethod will only re-encrypt the root key stored at thedefault root key ID location (0) and
GenerateNewRootKeywill only re-generate the root key stored at the default location. This PR updates these methods so that all root keys stored in the db are re-encrypted/re-generated respectively.This will fix an issue noticed in Litd: lightninglabs/lightning-terminal#549