lnd+config: add ability to obtain blocking and mutex profiles #7983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
blocking-and-mutex-profile
branch
from
5f29ebd
to
07c9b20
Compare
|
Pushed an update to allow the user to set the rate value themselves (0 to 1). |
Roasbeef
force-pushed
the
blocking-and-mutex-profile
branch
from
07c9b20
to
4af1aa4
Compare
yyforyongyu
requested review from
yyforyongyu
and removed request for
guggero
yyforyongyu
reviewed
Sep 14, 2023
ellemouton
approved these changes
Sep 14, 2023
| @@ -337,6 +337,9 @@ type Config struct { | |||
|
|
|||
| Profile string `long:"profile" description:"Enable HTTP profiling on either a port or host:port"` | |||
|
|
|||
| BlockingProfile int `long:"blockingprofile" description:"Used to enable a blocking profile to be served on the profiling port. This takes a value from 0 to 1, with 1 including every blocking event, and 0 including no events."` | |||
| MutexProfile int `long:"mutexprofile" description:"Used to Enable a mutex profile to be served on the profiling port. This takes a value from 0 to 1, with 1 including every blocking event, and 0 including no events."` | |||
|
|
|||
There was a problem hiding this comment.
perhaps worth updating the descriptions a bit so that it is clear which "blocking event" the individual profiles will look at? The description in the commit message is great 👍
Roasbeef
force-pushed
the
blocking-and-mutex-profile
branch
from
4af1aa4
to
12b5ae1
Compare
guggero
requested changes
Sep 18, 2023
In this commit, we add the ability to obtain blocking and mutex profiles. The blocking profile will show which goroutines are consistently blocked on synchronization primitives like channels, or I/O. The mutex profile will show which mutexes are very contested. The blocking profile can be enabled with a new arg: `--blockingprofile`. The mutex profile can be enabled with a new arg: `--mutexprofile`. These are both ignored if the profile port isn't set. Activating these profiles requires the caller to pass in a sampling rate. For now I've set it just to `1` to test things out. Unfortunately documentation is rather scarce, so there aren't any good guides re what these values should be set to. AFAICT, these add more overhead than the other prowling options, so they shouldn't necessarily be enabled persistently in production.
Roasbeef
force-pushed
the
blocking-and-mutex-profile
branch
from
12b5ae1
to
23a153a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we add the ability to obtain blocking and mutex profiles. The blocking profile will show which goroutines are consistently blocked on synchronization primitives like channels, or I/O. The mutex profile will show which mutexes are very contested.
The blocking profile can be enabled with a new arg:
--blockingprofile. The mutex profile can be enabled with a new arg:--mutexprofile. These are both ignored if the profile port isn't set.Activating these profiles requires the caller to pass in a sampling rate. For now I've set it just to
1to test things out. Unfortunately documentation is rather scarce, so there aren't any good guides re what these values should be set to. AFAICT, these add more overhead than the other prowling options, so they shouldn't necessarily be enabled persistently in production.