contractcourt: modify the incoming contest resolver to use concurrent… #8024
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Sep 25, 2023
Roasbeef
force-pushed
the
htlc-resolver-c-queue
branch
from
a15a9ce
to
31615e0
Compare
… queue In this commit, we modify the incoming contest resolver to use a concurrent queue. This is meant to ensure that the invoice registry subscription loop never blocks. This change is meant to be minimal and implements option `5` as outlined here: lightningnetwork#8023. With this change, the inner loop of the subscription dispatch method in the invoice registry will no longer block, as the concurrent queue uses a fixed buffer of a queue, then overflows into another queue when that gets full. Fixes lightningnetwork#7917
Roasbeef
force-pushed
the
htlc-resolver-c-queue
branch
from
31615e0
to
abe888f
Compare
yyforyongyu
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… queue
In this commit, we modify the incoming contest resolver to use a concurrent queue. This is meant to ensure that the invoice registry subscription loop never blocks. This change is meant to be minimal and implements option
5as outlined here:#8023.
With this change, the inner loop of the subscription dispatch method in the invoice registry will no longer block, as the concurrent queue uses a fixed buffer of a queue, then overflows into another queue when that gets full.
Fixes #7917