peer/test: fix race in TestHandleNewPendingChannel #8180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlaKC
changed the title
carlaKC
force-pushed
the
8128-brontideflake
branch
from
93b965a
to
1f1f677
Compare
Running test cases in parallel with shared state means that they can intermingle if they're run at the same time and set up incorrect values when we assert on the number of channels we have. Moving the peer setup into the parallel test run fixes this because no single test case can interfere with the other.
carlaKC
force-pushed
the
8128-brontideflake
branch
from
1f1f677
to
a8a86b2
Compare
yyforyongyu
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While flakehunting #8128, I ran into another flake in the
peertests:We're not getting the number of channels that we expect because the parallel test cases are all updating the same peer. It can therefore be the case that:
noop on active channelchecks how many channels we start with = 2new channel should be addedchecks how many channels we start with = 2new channel should be addedadds a new channel (bumping the count to 3)noop on active channelchecks how many channels we end with an unexpectedly sees 3 channelsThis all just depends on the order that the various test cases acquire the mutex for the underlying
sync.Mapthat's used to track channels. Easy fix - just move state setup into test run.