Minor improvements in the lncli api regarding channel closures. #8350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggie1984
force-pushed
the
rename-bumpclosefee
branch
from
dfba588
to
16adf71
Compare
ziggie1984
force-pushed
the
rename-bumpclosefee
branch
from
16adf71
to
171d2bd
Compare
guggero
reviewed
Jan 8, 2024
yyforyongyu
reviewed
Jan 8, 2024
ziggie1984
force-pushed
the
rename-bumpclosefee
branch
3 times, most recently
from
f8d26a9
to
b554256
Compare
BumpFee now returns a status signaling the success of the operation.
Replace (hide) the old bumpclosefee cmd with the new bumpforceclosefee cmd to avoid confusion which closing transactions can be bumped.
ziggie1984
force-pushed
the
rename-bumpclosefee
branch
from
b554256
to
2da06b0
Compare
ziggie1984
force-pushed
the
rename-bumpclosefee
branch
from
2da06b0
to
90f5dc3
Compare
guggero
approved these changes
Jan 9, 2024
| TargetConf: uint32(ctx.Uint64("conf_target")), | ||
| SatPerVbyte: ctx.Uint64(feeRateFlag), | ||
| Force: true, | ||
| }) |
There was a problem hiding this comment.
nit: closing parenthesis on new line.
| @@ -1067,6 +1067,8 @@ message BumpFeeRequest { | |||
| } | |||
|
|
|||
| message BumpFeeResponse { | |||
| // The status of the bump fee operation. | |||
| string status = 1; | |||
|
@ziggie1984, remember to re-request review from reviewers when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8309 in renaming the command to account for the fact that only force closes can be bumped using
bumpclosefee.Moreover it enables the
max_fee_raterpc option for theclosechannelcmd. By setting higher values than the normal x3 value of the ideal fee rate, the coop close can have a higher prob. to succeed.