Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvdb: embedded postgres upgrade to allow setting a custom max_connections config value #8419

Merged

Conversation

bhandras
Copy link
Collaborator

Change Description

This PR updates the embedded postgres dependency in the kvdb package to the latest tagged version (v1.25.0). This new version allows for setting the max_connection config value when starting the underlying Postgres instance. We parallelize some DB tests in #8100 which exhausts the connection limits so this PR is a pre-requirement for that.

Copy link

coderabbitai bot commented Jan 24, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: llm-review. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@bhandras bhandras added kvdb database Related to the database/storage of LND labels Jan 24, 2024
@bhandras bhandras self-assigned this Jan 24, 2024
@bhandras bhandras force-pushed the kvdb-embedded-postgres-upgrade branch from 8c3c99e to 560ea95 Compare January 24, 2024 20:39
Copy link
Collaborator

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will we hit the limit any time soon? If I am not confused embedded Postgres runs each test in its own database inside the same Postgres.

I guess the assumption here is that we will never run >200 tests using the DB concurrently?

@bhandras
Copy link
Collaborator Author

LGTM

Will we hit the limit any time soon? If I am not confused embedded Postgres runs each test in its own database inside the same Postgres.

I guess the assumption here is that we will never run >200 tests using the DB concurrently?

Thanks for the review Jordi! :)

I think we'll probably just go lower from here as we migrate away from kvdb. The default limits used to work as we didn't have as much concurrency before moving out the invoice update tests from channeldb to the invoices package. Over time as more and more db code migrates to sqldb we'll rely on the embedded Postgres less and less.

Copy link
Collaborator

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐦

Copy link
Collaborator

@saubyk saubyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@yyforyongyu yyforyongyu merged commit b9a8e2f into lightningnetwork:master Jan 25, 2024
24 of 25 checks passed
@bhandras bhandras deleted the kvdb-embedded-postgres-upgrade branch January 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Related to the database/storage of LND kvdb
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants