Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add confirmation prompt to closeallchannels #8526

Merged
merged 2 commits into from Mar 7, 2024
Merged

cli: add confirmation prompt to closeallchannels #8526

merged 2 commits into from Mar 7, 2024

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Mar 6, 2024

Fixes #6743.

@guggero guggero added safety General label for issues/PRs related to the safety of using the software cli Related to the command line interface no-itest labels Mar 6, 2024
@guggero guggero added this to the v0.18.0 milestone Mar 6, 2024
@guggero guggero requested a review from a team March 6, 2024 16:38
@guggero guggero requested a review from ellemouton as a code owner March 6, 2024 16:38
@guggero guggero requested review from bhandras and bitromortac and removed request for a team March 6, 2024 16:38
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: llm-review. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

hieblmi
hieblmi approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM 💾

cmd/lncli/commands.go
@@ -1012,6 +1017,11 @@ func closeAllChannels(ctx *cli.Context) error {
return err
}

prompt := "Do you really want to close ALL channels? (yes/no): "
if !ctx.Bool("skip_confirmation") && !promptForConfirmation(prompt) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

bitromortac
bitromortac approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍀

Chinwendu20
Chinwendu20 reviewed Mar 6, 2024
View reviewed changes
cmd/lncli/commands.go Outdated Show resolved Hide resolved
@Chinwendu20
Copy link
Contributor

Very useful PR. Nice.

ellemouton
ellemouton approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM 🔬

@guggero
cmd/lncli: add confirmation promt to closeallchannels
92ae54d 
To make sure users don't accidentally close all channels, we ask before
running this potentially very destructive command.
@guggero
docs: add release notes
bb5b614
@guggero guggero merged commit 5ccb9db into lightningnetwork:master Mar 7, 2024
18 checks passed
@guggero guggero deleted the confirm-closeallchannels branch March 7, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chinwendu20 Chinwendu20 Chinwendu20 left review comments

@hieblmi hieblmi hieblmi approved these changes

@ellemouton ellemouton ellemouton approved these changes

@bitromortac bitromortac bitromortac approved these changes

@bhandras bhandras Awaiting requested review from bhandras bhandras was automatically assigned from lightningnetwork/code-review

Assignees
No one assigned
Labels
cli Related to the command line interface no-itest safety General label for issues/PRs related to the safety of using the software
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.

i_know_what_i_am_doing option for closeallchannels
5 participants
@guggero @Chinwendu20 @hieblmi @ellemouton @bitromortac