-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead coinjoin implementations from docs/safety.md #8724
Conversation
Remove dead conjoin implementations
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏 a few nits
@@ -400,7 +400,7 @@ The following steps are recommended to cut all links between the old clearnet | |||
node and the new Tor node: | |||
1. Close all channels on the old node and wait for them to fully close. | |||
1. Send all on-chain funds of the old node through a Coin Join service (like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we are here, can we fix the s/Coin Join/CoinJoin typo? 🙏
@@ -400,7 +400,7 @@ The following steps are recommended to cut all links between the old clearnet | |||
node and the new Tor node: | |||
1. Close all channels on the old node and wait for them to fully close. | |||
1. Send all on-chain funds of the old node through a Coin Join service (like | |||
Wasabi or Samurai/Whirlpool) until a sufficiently high anonymity set is | |||
Joinmarket) until a sufficiently high anonymity set is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Joinmarket/JoinMarket
@@ -400,7 +400,7 @@ The following steps are recommended to cut all links between the old clearnet | |||
node and the new Tor node: | |||
1. Close all channels on the old node and wait for them to fully close. | |||
1. Send all on-chain funds of the old node through a Coin Join service (like | |||
Wasabi or Samurai/Whirlpool) until a sufficiently high anonymity set is | |||
Joinmarket) until a sufficiently high anonymity set is | |||
reached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this now fits on previous line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend edit the entire sentence to below:
If desired, take steps to preserve the onchain privacy of the funds from the old node
Does not make sense to call out any specific method or service here
Hi @LeoSpyke can take over this pr, if you don't have availability to address the recommendations |
@LeoSpyke, remember to re-request review from reviewers when ready |
Replaced by #8925. |
Change Description
Remove dead conjoin implementations from docs.