Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Label gets too long with Commitment and Event #110

Closed
adaburrows opened this issue Aug 6, 2022 · 2 comments
Closed

Feature: Label gets too long with Commitment and Event #110

adaburrows opened this issue Aug 6, 2022 · 2 comments

Comments

@adaburrows
Copy link
Member

adaburrows commented Aug 6, 2022

In issue #64, we introduced more information into the label in order to summarize both the commitment and the event. However, the built in edges in React Flow only supports text. So it shows up as an extremely long non-wrapping text box.

We should make a custom edge type that allows displaying HTML in it. According to the docs, the best way of doing this would be to add a custom edge with a <foreignObject /> that wraps our HTML. See: https://reactflow.dev/docs/examples/edges/edge-with-button/

@adaburrows adaburrows changed the title Feature: Add custom HTML labeled edge for Rect Flows. Feature: Add custom HTML labeled edge for React Flows. Aug 6, 2022
@adaburrows adaburrows changed the title Feature: Add custom HTML labeled edge for React Flows. Feature: Add custom HTML labeled edge for React Flows Aug 6, 2022
@adaburrows adaburrows changed the title Feature: Add custom HTML labeled edge for React Flows Feature: Add custom HTML labeled edge for React Flow Aug 6, 2022
@adaburrows adaburrows added this to the Minimum usability milestone Sep 7, 2022
@adaburrows adaburrows changed the title Feature: Add custom HTML labeled edge for React Flow Feature: Label gets too long with Commitment and Event Sep 14, 2022
@adaburrows
Copy link
Member Author

I think this should be closed in favor of #164, where we would no longer need to display all the information about the Intents, Commitments, and Events on the line, as they would become the nodes. This means we could actually create something of a hybrid between the original NYTL and Simon's Rock/Code A flow charts.

@adaburrows
Copy link
Member Author

Ok, I like what I'm thinking about in #164 and #170. In those scenarios, the label will no longer exist as a label, but will be a separate node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant