ci: add CI workflows for tests #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
ci
branch
4 times, most recently
from
a5a5ba7
to
a518be5
Compare
krichprollsch
force-pushed
the
ci
branch
2 times, most recently
from
3c2d0b3
to
61c5701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/Browsercore/project/issues/45
I had to configure an organization GH Personal Access Token to be able to clone private submodules.
I followed: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-fine-grained-personal-access-token
The token is stored in the CI secrets variables: https://github.com/Browsercore/browsercore/settings/secrets/actions
continue-on-error: trueconfiguration to force the job to pass instead.Unfortunately GH desn't give a way to warning a test instead of fail or success. see actions/runner#2347 for details.
I didn't found a better way to do that for now.
https://github.com/Browsercore/browsercore/pull/68/files#diff-f297e07b06710055241730fd4e30f4f97053e47d9a52e61234f4be3e7256bf41R57-R60