fix: remove leftover console.log

refactor: add eslint checks for leftover console logs
lightpohl · Feb 17, 2024 · 3135661 · 3135661
1 parent 4da2a14
commit 3135661
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -7,5 +7,8 @@
     "ecmaVersion": 2020,
     "sourceType": "module"
   },
-  "extends": ["eslint:recommended", "prettier"]
+  "extends": ["eslint:recommended", "prettier"],
+  "rules": {
+    "no-console": "warn"
+  }
 }
diff --git a/bin/logger.js b/bin/logger.js
@@ -1,3 +1,5 @@
+/* eslint-disable no-console */
+
 const ERROR_STATUSES = {
   general: 1,
   nothingDownloaded: 2,

diff --git a/bin/util.js b/bin/util.js
@@ -308,10 +308,12 @@ const logItemsList = ({
   });
 
   if (isJson) {
+    // eslint-disable-next-line no-console
     console.log(JSON.stringify(output));
     return;
   }
 
+  // eslint-disable-next-line no-console
   console.table(output);
 };
 
@@ -477,8 +479,6 @@ const getFileFeed = async (filePath, parserConfig) => {
   const config = parserConfig ? getJsonFile(parserConfig) : defaultConfig;
   const rssString = getFileString(filePath);
 
-  console.log(filePath, "rss string", rssString);
-
   if (parserConfig && !config) {
     logErrorAndExit(`Unable to load parser config: ${parserConfig}`);
   }
@@ -489,7 +489,7 @@ const getFileFeed = async (filePath, parserConfig) => {
   try {
     feed = await parser.parseString(rssString);
   } catch (err) {
-    logErrorAndExit("Unable to local RSS file", err);
+    logErrorAndExit("Unable to parse local RSS file", err);
   }
 
   return feed;