-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcre alternative #224
Comments
If there is no way of making an unmodified libpcre ecmascript-compatible (and I believe there isn't) I support using the Tamarin-modified copy. Tamarin is MPL/GPL/LGPL triple licensed and pcre itself is BSD licensed, so the license isn't a restriction. One problem would be security patches. We would either need to apply them to our copy of pcre ourselves or wait until Tamarin guys apply them and the sync the code. |
pcre from tamarin is forked from version 7.3 from 2007 and they don't seem to have updated it to more recent versions. |
Boost sound like a good candidate if it really is Ecmascript compatble. |
I've run a few tests with boost::regex, it seems to behave roughly the same as libpcre, so no luck :( |
The official version of libpcre that we are linking against has some issues regarding ecmascript compatibility.
Tamarin uses a modified version (http://hg.mozilla.org/tamarin-redux/file/5571cf86fc68/pcre) .
I've included that into my local repository of lightspark.
It works and fixes all the remaining regex tests.
So I think we should switch to this version and remove the dependency to libpcre.
Are there any issues ( licensing? ) that would speak against including this version of pcre?
The text was updated successfully, but these errors were encountered: