Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcre alternative #224

Closed
dbluelle opened this issue May 17, 2013 · 4 comments
Closed

pcre alternative #224

dbluelle opened this issue May 17, 2013 · 4 comments

Comments

@dbluelle
Copy link
Collaborator

The official version of libpcre that we are linking against has some issues regarding ecmascript compatibility.
Tamarin uses a modified version (http://hg.mozilla.org/tamarin-redux/file/5571cf86fc68/pcre) .
I've included that into my local repository of lightspark.
It works and fixes all the remaining regex tests.
So I think we should switch to this version and remove the dependency to libpcre.
Are there any issues ( licensing? ) that would speak against including this version of pcre?

@aajanki
Copy link
Contributor

aajanki commented May 18, 2013

If there is no way of making an unmodified libpcre ecmascript-compatible (and I believe there isn't) I support using the Tamarin-modified copy.

Tamarin is MPL/GPL/LGPL triple licensed and pcre itself is BSD licensed, so the license isn't a restriction.

One problem would be security patches. We would either need to apply them to our copy of pcre ourselves or wait until Tamarin guys apply them and the sync the code.

@dbluelle
Copy link
Collaborator Author

pcre from tamarin is forked from version 7.3 from 2007 and they don't seem to have updated it to more recent versions.
Maybe the regex implementation from boost is another alternative, they claim to be ecmascript compatible, see http://www.boost.org/doc/libs/1_53_0/libs/regex/doc/html/boost_regex/ref/syntax_option_type/syntax_option_type_perl.html

@aajanki
Copy link
Contributor

aajanki commented May 19, 2013

Boost sound like a good candidate if it really is Ecmascript compatble.

@dbluelle
Copy link
Collaborator Author

I've run a few tests with boost::regex, it seems to behave roughly the same as libpcre, so no luck :(
There is also a package boost::xpressive, which fixes some of the cases where libpcre failes, but
unfortunately it fails on a few other tests.
So far it looks like tamarin-pcre is currently the best choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants