Use react popper hooks #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdrdak
added a commit
that referenced
this pull request
Jul 6, 2020
* Leverage react-popper usePopper hook * remove old popper dependency * update changelog * fix lint
xdrdak
added a commit
that referenced
this pull request
Jul 17, 2020
* Add AlertInCard component. Auto color for Alert icons. (#82) * Add AlertInCard component. Auto color for Alert icons. * Update Alert/readme.md * Update CHANGELOG.md * Remove useless generic in getTheme * tiny fixes to match design specs * Update typing ignores * design feedback. remove useless typing * hush now codecov * Force add DSD specific icons if prop not filled * PR feedback Co-authored-by: maartenafink <maartenafink@gmail.com> * [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (#89) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * ForwardRef on Remaining Base Components (#75) * Forward ref on remaining base components * adjust changelog Co-authored-by: Guillaume Lambert <24464151+glambert@users.noreply.github.com> * Toaster component (#86) * Add toaster component WIP * Update jest and testing-library. Tests for toaster * Update toaster readme * remove dangling TODO from toaster * Add better responsiveness for Toaster * Restrict Toaster types. Bypass click events for ToasterContainer * Update changelog. Add notice that we are using an external lib * Remove unused typing file * Spread rest on Toaster component to auto-pause timer * Update toaster behaviour to match specs * Supress warnings for logs. Fix toaster example setup * less jarring height transition * fixing text alignment * Set minHeight for container at 60px * Test out Percy with animations Co-authored-by: maartenafink <maartenafink@gmail.com> Co-authored-by: Guillaume Lambert <24464151+glambert@users.noreply.github.com> * Move storybook down to package level. Update to 5.3 (#92) * port over previous tokens stories. Adapt for flame * Move dependencies to relevant package * disable css modules as its not really relevant anymore * update popover and tooltip story styling. sort top level sections * skip theme percy snapshots as per old implementation * Remove dead deps. Bubble ExampleBox from popover and tooltip * Move stories/ into flame/.storybook. Cleanup useless test * Fix percy command * Fix weird regression due to injecting components in style tags * Display themeGet and css for colours instead of classnames * Fix spaced group * Colours -> Colors * remove superflous react devDep * leverage top level packages Co-authored-by: Guillaume Lambert <24464151+glambert@users.noreply.github.com> * cleanup of top level storybook. Fix typing (#98) * Allow next to be published * Fix tests for alert. Move publish config to flame * Flush superfluous version due to merge * Fix typing issue in Dialog/Story * [Security] Bump acorn from 6.4.0 to 6.4.1 (#97) Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. **This update includes security fixes.** - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Xavier Drdak <1198051+xdrdak@users.noreply.github.com> * Publish - @lightspeed/flame@2.0.0-rc.0 * adjust publish scripts (#100) * Dummy changes to trigger release * Publish - @lightspeed/flame@2.0.0-rc.1 * Adjust line-height in Alert to be normal. (#101) * Adjust lineheight in Alert to be normal. * Update changelog * Adjust changelog to better sync up with release of RC * Publish - @lightspeed/flame@2.0.0-rc.2 * Fix code generation typing issue in build-themes * Publish - @lightspeed/flame@2.0.0-rc.3 * Fix Alert and AlertInCard typing. Allow empty title (#102) * Fix Alert and AlertInCard typing. Allow empty title * Update changelog * Publish - @lightspeed/flame@2.0.0-rc.4 * Use react popper hooks (#104) * Leverage react-popper usePopper hook * remove old popper dependency * update changelog * fix lint * Publish - @lightspeed/flame@2.0.0-rc.5 * Force Update active poppers. Fix clickOutside handler (#105) * add forceUpdate to Dropdown and Popover * Replace forceUpdate with update. Fix clickOutside hook * Update CHANGELOG.md * Set higher zIndex for ToasterContainer (#107) * set higher zIndex for ToasterContainer * Update CHANGELOG.md * Publish - @lightspeed/flame@2.0.0-rc.6 * Add next/Badge component (#106) * add next/Badge component * fix colors for oldskool theme * Update CHANGELOG.md * Let percy snapshot next * Use variant prop instead of type for badge * Update CHANGELOG.md * Adjust padding based on design feedback * Fix storybook publishing Co-authored-by: Guillaume Lambert <24464151+glambert@users.noreply.github.com> * Publish - @lightspeed/flame@2.0.0-rc.7 * Smoothed out border-radius for next/Badge (#108) * Smoothed out border-radius for next/Badge * Update CHANGELOG.md * Export typing for next/Badge (#110) * export typing for next/Badge * Update CHANGELOG.md * Create (S)CSS-flavored Flame implementation package (#109) * Port sass as is into flame * Apply suggestions from code review Co-authored-by: Guillaume Lambert <24464151+glambert@users.noreply.github.com> * Update css README docs. Remove media queries css as this is out of scope * Remove private flag from flame-css Co-authored-by: Guillaume Lambert <24464151+glambert@users.noreply.github.com> * Publish - @lightspeed/flame-css@0.1.0 - @lightspeed/flame@2.0.0-rc.8 * Move Storybook back to root again (#111) * move everything back to root * strip magic from storybook-components. Adjust root package scripts * Mute typings for withReadme * Fix netlify build path * Fix storybook decorator injection condition * Add chromatic workflow (#112) * Remove percy. Adjust old percy stuff for chromatic (#114) * Adjust chromatic workflow * Use tags as target for publish action. Snapshot label for visual diffing (#115) * Target tags for action. Snapshot on label * Pushes on master will trigger a snapshot * Add "type=text" to input for convenience (#117) * Publish - @lightspeed/flame-css@0.1.1 - @lightspeed/flame@2.0.0-rc.9 * Adjust publishing scripts. Dummy changes to trigger publish * Publish - @lightspeed/flame@2.0.0-rc.10 Co-authored-by: maartenafink <maartenafink@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Guillaume Lambert <24464151+glambert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New usePopper hook is a much more stable solution than the homegrown hook.
This will cause breakage though for users who are leveraging the existing "usePopper" hook.
How to test?
yarn devChecklist