Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase-1/add/7 - Verify the default and search grid and list layouts work on the post type archive #22

Closed
wants to merge 20 commits into from
Closed

Phase-1/add/7 - Verify the default and search grid and list layouts work on the post type archive #22

wants to merge 20 commits into from

Conversation

jlaguma
Copy link

@jlaguma jlaguma commented Mar 11, 2020

Description

List and grid layouts on archive page work. Made sure that templates work with LSX Search on and off. Made sure that templates are looking like designs.

Code changes

  • Tweaks to get_formatted_taxonomy_str() function in template-tags.php to add support of links in industries.
  • Rebuilt single-row-business.php template to match designs.
  • Added single-col-business.php template to add grid functionality matching the designs.
  • Tweaks to archive-business-directory.php template to make sure stuff works well with LSX Search on or off.

Tests done

  • List layout works with LSX Search on or off.
  • Grid layout works with LSX Search on or off.
  • Facet filters, sorting, searching works.

Issue

#7

James La Guma added 20 commits February 25, 2020 11:39
phase-1/add/4 - Configure Settings page for Business Directories: #4
37d4c9e
travis complaining about string variable
b3af95a
travis complaining about string variable
80dd9f0
travis complaining about string variable
fbfa20c
phase-1/add/5 - Configure Settings page for General and Search settin…
ffa8a0d 
…gs: #5
touch up
009948b
phase-1/add/9 - Verify the single template works, and pull through th…
4355f17 
…e new custom fields: #9
phase-1/add/9 - Verify the single template works, and pull through th…
b811f90 
…e new custom fields: #9
travis fixes
579346e
travis fixes
bbe1572
travis fixes
9e14016
typo
901561a
travis fixes
aab0f61
travis fixes
e98eb4f
scripts rename
f6f1e8f
archive pages wip
d60eec1
archive list and grid layouts work
74169ee
archive list and grid layouts work
092dcca
archive list and grid layouts work
f52828d
archive list and grid layouts work
697f24a
@jlaguma jlaguma added the enhancement New feature or request label Mar 11, 2020
@jlaguma jlaguma added this to the 1.0.0 - Phase 1 + 2 milestone Mar 11, 2020
@jlaguma jlaguma requested a review from krugazul March 11, 2020 08:16
@jlaguma jlaguma self-assigned this Mar 11, 2020
@jlaguma jlaguma linked an issue Mar 11, 2020 that may be closed by this pull request
Verify the default and search grid and list layouts work on the post type archive #7
Closed
3 tasks
@jlaguma jlaguma mentioned this pull request Mar 11, 2020
Closed
3 tasks
@krugazul krugazul closed this Mar 11, 2020
@krugazul
Copy link
Contributor

@jlaguma this pull request was to merge into master, i have created one to merge into the phase 1 branch. #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krugazul krugazul Awaiting requested review from krugazul

Assignees

@jlaguma jlaguma

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0 - Phase 1 + 2
Development

Successfully merging this pull request may close these issues.

Verify the default and search grid and list layouts work on the post type archive
2 participants
@jlaguma @krugazul