Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSX Design: 1.3.1 styling updates - Woocomemrce bug fixes #132

Merged
merged 2 commits into from
Jul 5, 2024
Merged

LSX Design: 1.3.1 styling updates - Woocomemrce bug fixes #132

merged 2 commits into from
Jul 5, 2024

Conversation

Justinabes007
Copy link
Contributor

LSX 1.3.0 theme Bug issues identified

3 Small bugs were identified following the launch of LSX Design Block theme 1.3.0

  1. Woocomemrec Checkout Block - Iinput Radio option - alignments issue - LSX Design - Checkout Block display bug  #129
  2. Woocomemrce Cart Block - Iinput Radio option - alignments issue - LSX Design - Woocomemrce Cart block: Styling conflicts #130
  3. Blog Pagination is Broken if Woocommerce is not installed - LSX Design - Blog pagination display issue  #131

Fixes applied to resolve the issue as per designs:

Changes made to 2 Files:

  1. Woocomemrce.css - to resolve the Input radio button alignment
  2. style.css - Pagination styling improvements and replicated design.

Closes #129
Closes #130
Closes #131

Changelog Entry

[1.3.1]

LSX

Updated

  • woocommerce.css - styling improvements for Cart & Checkout
  • style.css - Pagination styling updates and improvements, hovers, active states

@Justinabes007 Justinabes007 added the Needs Technical Feedback Needs testing from a developer perspective. label Jul 5, 2024
@Justinabes007 Justinabes007 added this to the 1.3.1 milestone Jul 5, 2024
@Justinabes007 Justinabes007 self-assigned this Jul 5, 2024
krugazul
krugazul approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@krugazul krugazul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Justinabes007 I have gone through the changes and tested the issues, they are working as expected. The theme has passed the checks as well.

closes #129, #130, #131

Screenshot 2024-07-05 at 11 26 28

@krugazul krugazul merged commit eb60e3c into main Jul 5, 2024
3 of 4 checks passed
@krugazul krugazul deleted the 1.3.1-styling-updates branch July 5, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krugazul krugazul krugazul approved these changes

Assignees

@Justinabes007 Justinabes007

Labels
Needs Technical Feedback Needs testing from a developer perspective.
Projects
None yet
Milestone
1.3.1
2 participants
@Justinabes007 @krugazul