Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression in OTel-Go metrics API v0.38.x #446

Open
jmacd opened this issue May 4, 2023 · 0 comments
Open

Performance regression in OTel-Go metrics API v0.38.x #446

jmacd opened this issue May 4, 2023 · 0 comments

Comments

@jmacd
Copy link
Member

jmacd commented May 4, 2023

Describe the bug
The new functional-option call pattern for synchronous metric instruments adds 4 allocations to every former ...attribute.KeyValue call site unless the code can be rewritten.

To Reproduce
New benchmarks will be added (PR T.B.D.)

Expected behavior
When a metrics operation repeats an attribute set that has recently been used, there will be zero allocations even when using a []attribute.KeyValue.

Additional context
See open-telemetry/opentelemetry-go#4052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant