Add the Exponential Histogram and other aggregators for review LS-29757 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njvrzm
suggested changes
Jun 7, 2022
There was a problem hiding this comment.
Mostly minor notes, for most of which I've made suggestions this time. I'm requesting changes because I think UpdateByIncr should return immediately if incr is 0, to avoid both unnecessary work and a possible bug, but if I've misunderstood something please feel free to disregard that.
…launcher-go into jmacd/review_expohisto
…uncher-go into jmacd/review_expohisto
❤️ Co-authored-by: Nathan Vērzemnieks <njvrzm@gmail.com>
njvrzm
approved these changes
Jun 7, 2022
paivagustavo
reviewed
Jun 8, 2022
njvrzm
reviewed
Jun 8, 2022
jmacd
added a commit
to lightstep/go-expohisto
that referenced
this pull request
Oct 5, 2022
contained in these OpenTelemetry-Go PRs: open-telemetry/opentelemetry-go#2982 open-telemetry/opentelemetry-go#2502 The data structure was reviewed by Lightstep engineers for inclusion in otel-launcher-go: lightstep/otel-launcher-go#174 lightstep/otel-launcher-go#215 lightstep/otel-launcher-go#222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The aggregators (Sum, Gauge, and Exponential Histogram) are contained in this review. The Sum and Gauge aggregators are trivial, however the exponential histogram needs serious review.
Link to tracking Issue:
LS-29760 describes the overall goal; this is one part.
Testing:
End-to-end testing was done. The alt_metrics_sdk/development branch has a assembled copy of this code. Depends on various Lightstep-side PRs merging to see the exponential histograms work.