Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing legacy name for param OTEL_RESOURCE_LABELS #13

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Conversation

obecny
Copy link
Contributor

@obecny obecny commented Aug 13, 2020

fixing LS-18932

@obecny obecny requested a review from mwear August 13, 2020 22:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #13 into master will increase coverage by 0.80%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   72.72%   73.52%   +0.80%     
==========================================
  Files           5        5              
  Lines         132      136       +4     
  Branches       21       22       +1     
==========================================
+ Hits           96      100       +4     
  Misses         36       36              
Impacted Files Coverage Δ
src/lightstep-opentelemetry-launcher-node.ts 92.92% <100.00%> (+0.29%) ⬆️

Copy link
Contributor

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'll make a ticket to track the removal pending a future OTel release.

@mwear mwear merged commit bb34fa5 into master Aug 14, 2020
@codeboten codeboten deleted the env_fix_name branch December 2, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants