Add new Host Metrics dashboard #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nslaughter
reviewed
Oct 5, 2023
| } | ||
| } | ||
|
|
||
| text_panel { |
There was a problem hiding this comment.
nit: to me it's simpler to read this config if the descriptive metadata comes first. It's not a requested change unless we're just falling into convention or default we could change elsewhere.
There was a problem hiding this comment.
I tend to agree, and I'll make the change. The thing is though, I made this Terraform config by using our Terraform exporter tool, which places text_panels at the bottom of a group in a config file. You'll notice from the x_pos and y_pos that this text panel will show up first in the actual dashboard.
nslaughter
reviewed
Oct 5, 2023
What does this PR do? --------------------- - Adds a new Host Metrics dashboard under collector-dashboards/otel-collector-host-metrics-dashboard and adds the dashboard to README.md, main.tf, and outputs.tf - Fixes some typos For what purpose? --------------------- The main purpose of this change is to add a new Host Metrics dashboard. It's essentially the OTel-native hostmetricsreceiver equivalent of the Host Metrics (Prometheus) dashboard. Adding it here will allow us to make it available in the prebuilt dashboard library.
gdfast
force-pushed
the
gfast/add-host-metrics-dashboard
branch
from
f9a9d4d
to
0e2ea1f
Compare
adil-sultan
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For what purpose?
The main purpose of this change is to add a new Host Metrics dashboard. It's essentially the OTel-native hostmetricsreceiver equivalent of the Host Metrics (Prometheus) dashboard. Adding it here will allow us to make it available in the prebuilt dashboard library.
PR checklist
Please confirm the following items: