Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement go mod #139

Closed
wants to merge 13 commits into from
Closed

Implement go mod #139

wants to merge 13 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 15, 2019

  • Implements Go mod
  • Removes Godep
  • Updates README.md

@ghost
Copy link
Author

ghost commented May 15, 2019 •
edited by ghost

if #140 gets merged first we may need to re-run go mod vendor and pull back the latest version of geth

@ggarri ggarri mentioned this pull request May 16, 2019
Open
@EnchanterIO
Copy link
Contributor

EnchanterIO commented May 27, 2019 •
edited

This task also requires to upgrade all of our docker images to at least Go version 1.11

FYI: @iris-garcia @ggarri

@ghost
Copy link
Author

ghost commented May 27, 2019

yes, thanks for the heads-up. I've forgotten the dockerfile.

@EnchanterIO
Copy link
Contributor

Thx for updating it! In the comment about docker images I was just leaving a note for myself actually, referring to our infrastructure :)

Diego, do you think is worth it to update directly to go 1.12?

@ghost
Copy link
Author

ghost commented May 30, 2019

yes, probably worth it if it doesn't break any deps

@ghost ghost closed this Aug 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@EnchanterIO