Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

nbc-2.com - images don't show up and site layout messed up #39

Closed
AmperAndSand opened this issue Nov 7, 2018 · 3 comments
Closed

nbc-2.com - images don't show up and site layout messed up #39

AmperAndSand opened this issue Nov 7, 2018 · 3 comments
Labels
broken-site Valid block breaks a legit site

Comments

@AmperAndSand
Copy link

AmperAndSand commented Nov 7, 2018

http://www.nbc-2.com/story/39429662/man-arrested-for-threatening-to-shoot-up-pennsylvania-polling-place

The site layout is jumbled up and images don't show up due to the following host names being blocked (present in both ads-and-tracking.txt and ads-and-tracking-extended.txt):

  • franklyinc.com
  • ngw-static.franklyinc.com

Screenshot:
screenshot

@lightswitch05
Copy link
Owner

This is unfortunate. The script has nothing to do with the content. They have lazy loading - but no error handling. When they get a JavaScript error from a blocked tracker - it breaks everything else on the page that requires JavaScript (the lazy loader)

        <script src="https://ngw-static.franklyinc.com/assets/8685/app-c0b1f53218264d15306e.js"></script>
        <!-- NOTE: if AppNexus Prebid is enabled, add its script.-->
        
        <script src="https://content.worldnow.com/global/js/_pub/off-platform.ads.min.js?ver=0"></script>
        <script>
          Worldnow.Beacon.set(
            _.mergeWith(franklyDataLayer[0], Worldnow.Beacon.get(), function customizer(dataLayerValue, beaconValue) {
              if (!beaconValue || beaconValue === 'null' || beaconValue === 'undefined' || beaconValue === 'n/a' || beaconValue === 'error not found!') {
                return dataLayerValue;
              }
            })
          );
        </script>

Worldnow.Beacon.set is the breaking JavaScript - since it is being blocked

@lightswitch05 lightswitch05 added the broken-site Valid block breaks a legit site label Nov 7, 2018
@lightswitch05
Copy link
Owner

It does look like it handles some of the CSS and the weather widget too

@lightswitch05
Copy link
Owner

@AmperAndSand removed, thanks for the report

lightswitch05 added a commit that referenced this issue Jul 5, 2019
lightswitch05 added a commit that referenced this issue Jul 5, 2019
lightswitch05 added a commit that referenced this issue Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
broken-site Valid block breaks a legit site
Projects
None yet
Development

No branches or pull requests

2 participants