[mod_cgi] consolidate CGI cleanup code #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reference: "Race leads to incorrect output in some circumstances" https://redmine.lighttpd.net/issues/2542 (Thx, anomie, who identified and explained problem in above ticket)
(more consistent behavior) reference: "Race leads to incorrect output in some circumstances" https://redmine.lighttpd.net/issues/2542
wait for CGI to close stdout, so we read EOF on pipe to end CGI response remove extra call to waitpid() which will occur after process exits if it has not already been explicitly closed by CGI (and has not been inherited by CGI forked children) (If CGI forks, then it should close its stdout response pipe when response is done, especially if it intends to perform lengthy post-processing in the background.)
(clean up potential zombie processes from unreaped children)
|
Thanks! Applied in dde7bea. |
|
@stbuehler, there is a whole lot more in this patch than just the last commit of the 4 commits in this branch. Would you take another look? Would you rather me squash them all together? |
|
oh, I see. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(more consistent behavior)
reference:
"Race leads to incorrect output in some circumstances"
https://redmine.lighttpd.net/issues/2542