Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution of local Maven artefacts does not work #611 #612

Closed
wants to merge 1 commit into from

Conversation

mduerig
Copy link

@mduerig mduerig commented May 23, 2017

Add resolver for local Maven cache

@alexarchambault
Copy link
Collaborator

I wouldn't recommend adding ~/.m2/repository by default. It sometimes misses artifacts (like it has the POMs but not the JARs), which confuses coursier - if a repo has a POM, coursier expects it to have the JAR too... I could add a helper in coursier (like coursier.MavenRepository.m2Local) to make it easier to add it from ammonite though.

@mduerig
Copy link
Author

mduerig commented May 23, 2017

coursier.MavenRepository.m2Local would be a better solution and nicely inline with coursier.Cache.ivy2Local.

@alexarchambault
Copy link
Collaborator

Possibly even coursier.Cache.m2Local :-) Or I wanted to move ivy2Local under coursier.IvyRepository...

@lihaoyi
Copy link
Member

lihaoyi commented May 23, 2017

@mduerig Regardless of what changes you end up doing to coursier, do you still want to add it by default to Ammonite's resolvers? If not you can always add it manually in your own predef/earlier-block, and I'll close this issue/PR

@mduerig
Copy link
Author

mduerig commented May 23, 2017

@lihaoyi , I agree with @alexarchambault that this is better tackled in one way or another in coursier. Once this is done we can get back to this issue and see how to fix it. In the meanwhile let's close the PR.

@lihaoyi
Copy link
Member

lihaoyi commented May 23, 2017

sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants