Properly handle cuts in LHS of flatMap calls and Not/Lookahead/Filter #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not properly propagating the
cut
s in the LHS offlatMap
s; that meant that if there was acut
inside the left hand parser, it doesn't take effect if something fails in the RHS of theflatMap
call, or if theflatMap
succeeds but something fails later.Also makes
!
and&
negative/positive lookaheads behave asNoCut
s: the whole point of those operators is to backtrack, so there isn't any conceivable use-case where someone would want to use them and have a cut disable-backtracking/drop-buffer when inside one of these operators.Also properly propagates cuts in
foo.filter(pred)
whenfoo
passes butpred
fails.Found these when investigating the build failure in #122. Possibly not the only issue, but it's something. This changes behavior, but if this makes any tests fail, I'll fix them.
Review by @vovapolu