Polish and documentation work for fastparse.byte #125
Conversation
lihaoyi
force-pushed
the
optimize
branch
9 times, most recently
from
c1c8972
to
01a474a
Compare
|
This is basically ready now the build is green; when #122 lands I'll squash everything and clean this up for review |
|
It's getting complicated :) There are 2 PRs and you pushed new commit here. |
|
Oops, yeah lemme push to the other one |
|
Ok, time to clean this up and now that #122 has landed |
…leanup and
tweaks and docs to help polish the API
- Optimize `[U]Int{8, 16, 32, 64}` to avoid allocating temporary arrays and byte buffers
- Add `Float32` and `Float64` parsers
- Swap the order of arguments in `repeatWithLength`, so it matches the order of parsing
- Make `hexBytes` more forgiving to whitespace, so it works with multi-line strings
- Remove `ByteSeq` alias since we already have `BS`
- Re-arrange the `ElemsX`/`ByteX`/`CharX` parsers; give the `ByteX`/`CharX` parsers toStrings
that match their ByteX/CharX names
- Move `prettyBytes` into the main `fastparse.byte` API, document it
- Add `AnyElems`/`AnyBytes`/`AnyChars` parser, for quickly chomping arbitrary
fixed-length input.
- Update existing parsers to make heavy use of `AnyBytes`, `WordN`, and `IntN` parsers
- Add a ton of minimal-example docs for all the byte specific parsers
- Add a new faux-struct parser to be the intro example for byte parsers, move UDP parser
down into "example byte parsers" section
lihaoyi
changed the title
| s"Cannot show indices $markers outside input bounds 0 -> ${bytes.length}" | ||
| ) | ||
|
|
||
| val maxIndexWidth = math.floor(math.max(0, math.log10(99))).toInt + 1 |
There was a problem hiding this comment.
lol nice catch, yeah that should be bytes.length
|
@lihaoyi New tests are wrong, and there is also some big debug output for new midi parser that distracts a little. |
|
Oh wat, I thought I had things running green before pushing. Lemme take a look |
|
Looks like it was a JS/JVM incompatibility; I only tested it on JVM locally. Will fix |
|
Turns out |
| @@ -21,7 +21,7 @@ object ByteUtils{ | |||
| s"Cannot show indices $markers outside input bounds 0 -> ${bytes.length}" | |||
| ) | |||
|
|
|||
| val maxIndexWidth = math.floor(math.max(0, math.log10(bytes.length))).toInt + 1 | |||
| val maxIndexWidth = bytes.length.toString.length | |||
This is a bit of a big/messy diff, that basically includes a lot of cleanup and tweaks and docs to help polish the API
[U]Int{8, 16, 32, 64}to avoid allocating temporary arrays and byte buffersFloat32andFloat64parsersrepeatWithLength, so it matches the order of parsinghexBytesmore forgiving to whitespace, so it works with multi-line stringsByteSeqalias since we already haveBSElemsX/ByteX/CharXparsers; give theByteX/CharXparsers toStringsthat match their ByteX/CharX names
prettyBytesinto the mainfastparse.byteAPI, document itAnyElems/AnyBytes/AnyCharsparser, for quickly chomping arbitraryfixed-length input.
AnyBytes,WordN, andIntNparsersdown into "example byte parsers" section