Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add osgi headers #32

Merged
merged 2 commits into from
Jul 5, 2017
Merged

add osgi headers #32

merged 2 commits into from
Jul 5, 2017

Conversation

tpolecat
Copy link
Contributor

@tpolecat tpolecat commented Jun 27, 2017

This adds OSGi headers to the jar manifests, which I need downstream to support OSGi in doobie. The end result is that META-INF/MANIFEST.MF now looks like:

Manifest-Version: 1.0
Bnd-LastModified: 1498590525574
Bundle-Description: sourcecode
Bundle-ManifestVersion: 2
Bundle-Name: sourcecode
Bundle-SymbolicName: com.lihaoyi.sourcecode
Bundle-Vendor: com.lihaoyi
Bundle-Version: 0.1.4
Created-By: 1.8.0_65 (Oracle Corporation)
DynamicImport-Package: *
Export-Package: sourcecode;uses:="scala,scala.collection,scala.collectio
 n.immutable,scala.reflect,scala.reflect.api,scala.reflect.macros.blackb
 ox,scala.runtime";version="0.1.4.SNAPSHOT"
Import-Package: scala;version="[2.12,3)",scala.collection;version="[2.12
 ,3)",scala.collection.generic;version="[2.12,3)",scala.collection.immut
 able;version="[2.12,3)",scala.collection.mutable;version="[2.12,3)",sca
 la.math;version="[2.12,3)",scala.reflect;version="[2.12,3)",scala.refle
 ct.api;version="[2.12,3)",scala.reflect.internal;version="[2.12,3)",sca
 la.reflect.internal.util;version="[2.12,3)",scala.reflect.macros,scala.
 reflect.macros.blackbox;version="[2.12,3)",scala.reflect.macros.context
 s;version="[2.12,3)",scala.runtime;version="[2.12,3)",scala.tools.nsc;v
 ersion="[2.12,3)",scala.tools.nsc.ast.parser;version="[2.12,3)"
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
Tool: Bnd-2.4.0.201411031534

@tpolecat
Copy link
Contributor Author

I'm not sure how you do versioning so I bumped it in build.sbt.

@lihaoyi
Copy link
Member

lihaoyi commented Jul 5, 2017

I have no clue how OSGI works but you seem like you know what you're doing

@lihaoyi lihaoyi merged commit fe5f236 into com-lihaoyi:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants