UI modularization: Create new module 'RuleDetail' and extract common components #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I916ab36fcde60d2e0e8783d770506a31d0d8ad68
Change-Id: I7ec199134d33f09ab4af1f4445b3406cfccf6d3d
Change-Id: Ic8e7dce5d9e5e86bd807619216553eeefd86bc97 # Conflicts: # feature/appdetail/src/main/java/com/merxury/blocker/feature/appdetail/cmplist/ComponentListContent.kt
Change-Id: Ic7780c8407450ccc20f1fc1d5e75775a825c63ab
Change-Id: Ice290c05f1f604759f0745926543743784e6f6e5
2. Add a common LoadingScreen and ErrorScreen in ui
2. NavigateToRuleDetailScreen when clicking ruleCard on SearchResultScreen
2. Use AppList in AppListScreen and SearchResultScreen
lihenggui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compose update