Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the bell "\u0007" character #39

Closed
lihop opened this issue Jun 20, 2021 · 0 comments · Fixed by #47
Closed

Support the bell "\u0007" character #39

lihop opened this issue Jun 20, 2021 · 0 comments · Fixed by #47
Assignees
@lihop
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lihop
Copy link
Owner

lihop commented Jun 20, 2021 •
edited
Loading

With the upgrade of libtsm in d2f073d, we now have a callback for the bell character (ascii 07). This means we can emit a bell_rang signal when the bell character is "rung" which could then be connected to an AudioStreamPlayer node.
@lihop lihop added enhancement New feature or request good first issue Good for newcomers labels Jun 20, 2021
@lihop lihop self-assigned this Jul 3, 2021
lihop added a commit that referenced this issue Jul 3, 2021
@lihop
Add support for the bell "\a" character
f2dc622 
Closes #39
@lihop lihop mentioned this issue Jul 3, 2021
Merged
lihop added a commit that referenced this issue Jul 3, 2021
@lihop
Add support for the bell "\a" character
2441b10 
Closes #39
@lihop lihop closed this as completed in #47 Jul 3, 2021
lihop added a commit that referenced this issue Jul 3, 2021
@lihop
Add support for the bell "\a" character
09dc080 
Closes #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lihop lihop

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for the bell "\a" character lihop/godot-xterm
1 participant
@lihop