Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect intial PTY size when used with Terminal #56

Closed
lihop opened this issue Aug 10, 2022 · 0 comments
Closed

Incorrect intial PTY size when used with Terminal #56

lihop opened this issue Aug 10, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@lihop
Copy link
Owner

lihop commented Aug 10, 2022

When running the terminal example scene the initial PTY size does not match the Terminal size but rather the default of 24x80.

Expected:
2022-08-11-094307_398x65_scrot

Actual:
2022-08-11-094243_464x103_scrot

This results in some undesirable behaviour:
2022-08-11-094211_798x529_scrot
2022-08-11-094204_798x529_scrot

This is fixed after resizing the Terminal (for example, by resizing the application window) so it emits the size_changed() signal, causing PTY to update to the correct size:
2022-08-11-094313_798x529_scrot
2022-08-11-094326_798x529_scrot

@lihop lihop added the bug Something isn't working label Aug 10, 2022
lihop added a commit that referenced this issue Aug 12, 2022
If a PTY has a terminal_path set to a valid Terminal, then ensure that
the initial cols and rows of PTY match the cols and rows of the Terminal
when calling fork() or open(), otherwise PTY will output wrong-sized
data for the Terminal until resized.

Fixes #56.
lihop added a commit that referenced this issue Aug 14, 2022
If a PTY has a terminal_path set to a valid Terminal, then ensure that
the initial cols and rows of PTY match the cols and rows of the Terminal
when calling fork() or open(), otherwise PTY will output wrong-sized
data for the Terminal until resized.

Fixes #56.
@lihop lihop closed this as completed in 054c7c9 Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant