Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to End Tests with Cypress - Setup #713

Closed
wants to merge 9 commits into from

Conversation

mburri
Copy link
Member

@mburri mburri commented Nov 10, 2023

I analyzed the existing implementation for deployments affecting #353. I quickly realized that there would be a huge potential for refactorings, but often the test coverage is not sufficient to support efficient refactorings.

Writing new unit tests would be possible, but is often quite difficult due to the number of dependent services, repositories
and boundaries that must be mocked away. In addition, mocking all these dependencies actually makes it harder to refactor, since the mocks couple the test to the actual implementation.

Anyway. Having end-to-end tests that cover the main paths of the application would be helpful. There was an e2e test setup in the AMW_angular module. But:

So I removed the protractor from the AMW_angular module.

Then I decided to create a separate module for the end-to-end testing, because the whole application is affected, not just the parts implemented in Angular.

For now, this is just the setup with a very simple test to show, that the setup is correct.

This PR adds a dedicated Github Action Workflow to run the end-to-end tests. But there are lots of overlappings with the existing build and test action. The e2e tests could also be added to the existing workflow.

Please feel free to suggest changes, improvements or even reject this PR

@mburri
Copy link
Member Author

mburri commented Nov 10, 2023

I accidentally included some commits from another PR in this branch. The branch cannot be changed, so I'm closing this PR and will open a new one.

@mburri mburri closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants