Add some missing arguments type in PHPDoc #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
approved these changes
Jun 7, 2019
|
@fsevestre Please rebase your branch on |
|
@alexislefebvre Done |
|
Thanks! |
|
The changes you mentioned first can be done in https://github.com/liip/LiipTestFixturesBundle/blob/1.0.0/src/Test/FixturesTrait.php#L96 too. The code has been extracted between 2.x and 3.x to this new bundle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our project, we got an error from PHPStan because we override theloadFixtureFilesand the PHPDoc is not in synch with the function declaration.Well, after changing the branch to 3.x, there are not that much of missing arguments type ^^