add comment about DI fallback

liip · Jun 3, 2015 · 658148d · 658148d
1 parent 2c2e235
commit 658148d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/DependencyInjection/Factory/Resolver/AwsS3ResolverFactory.php b/DependencyInjection/Factory/Resolver/AwsS3ResolverFactory.php
@@ -20,6 +20,7 @@ public function create(ContainerBuilder $container, $resolverName, array $config
         if (method_exists($awsS3ClientDefinition, 'setFactory')) {
             $awsS3ClientDefinition->setFactory(array('Aws\S3\S3Client', 'factory'));
         } else {
+            // to be removed when dependency on Symfony DependencyInjection is bumped to 2.6
             $awsS3ClientDefinition->setFactoryClass('Aws\S3\S3Client');
             $awsS3ClientDefinition->setFactoryMethod('factory');
         }

diff --git a/DependencyInjection/LiipImagineExtension.php b/DependencyInjection/LiipImagineExtension.php
@@ -129,8 +129,10 @@ private function setFactories($container)
         foreach ($factories as $service => $factory) {
             $definition = $container->getDefinition($service);
             if (method_exists($definition, 'setFactory')) {
+                // to be inlined in imagine.xml when dependency on Symfony DependencyInjection is bumped to 2.6
                 $definition->setFactory($factory);
             } else {
+                // to be removed when dependency on Symfony DependencyInjection is bumped to 2.6
                 $definition->setFactoryClass($factory[0]);
                 $definition->setFactoryMethod($factory[1]);
             }