Merge pull request #1453 from liip/fix/file-get-contents-can-false

file_get_contents might return false. related to #1452
liip · Feb 9, 2022 · a77cd62 · a77cd62
2 parents 2d6c47c + 6d8b97a
commit a77cd62
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Binary/BinaryInterface.php b/Binary/BinaryInterface.php
@@ -14,7 +14,7 @@
 interface BinaryInterface
 {
     /**
-     * @return string
+     * @return string|false
      */
     public function getContent();
 

diff --git a/Model/FileBinary.php b/Model/FileBinary.php
@@ -43,7 +43,9 @@ public function __construct($path, $mimeType, $format = null)
     }
 
     /**
-     * @return string
+     * TODO: in version 3, restrict return type to string and throw an exception when file_get_contents fails.
+     *
+     * @return string|false
      */
     public function getContent()
     {