Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Update Amazon S3 service RST docs to include version argument #1056

Merged

Conversation

robfrawley
Copy link
Collaborator

Q A
Branch? 2.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1000
License MIT
Doc PR

This PR fixes our documentation for creating Amazon S3 services as reported by @rsaenen in #1000. Apparently newer versions of the Amazon S3 library require the usage of a version option specifying the API release to use for communication with their service.

@robfrawley robfrawley added Type: Documentation This item pertains to documentation of this project. State: Confirmed This item has been confirmed by maintainers as legitimate. Attn: Minor This issue or PR is a minor problem or minor change. labels Feb 18, 2018
@robfrawley robfrawley added this to the 2.0.0 milestone Feb 18, 2018
@robfrawley robfrawley changed the title [Documentation] Update Amazon S3 service documentation to include version option [Documentation] Update Amazon S3 service RST docs to include version argument Feb 18, 2018
@robfrawley robfrawley force-pushed the bugfix-update-amazon-s3-service-documentation branch from 1a498a2 to 9b26176 Compare February 18, 2018 08:53
@robfrawley robfrawley mentioned this pull request Feb 18, 2018
@maximgubar
Copy link
Contributor

@robfrawley could you please resolve conflicts, so we could process this PR ?

@robfrawley robfrawley force-pushed the bugfix-update-amazon-s3-service-documentation branch from 9b26176 to 16e7b4e Compare May 12, 2018 03:21
@robfrawley robfrawley merged commit 6b5f04c into liip:2.0 May 12, 2018
@robfrawley
Copy link
Collaborator Author

Done @maximgubar! Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attn: Minor This issue or PR is a minor problem or minor change. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Documentation This item pertains to documentation of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants