Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-functional allow_upscale reference #1257

Merged
merged 1 commit into from Jan 2, 2020
Merged

Conversation

Yopai
Copy link
Contributor

@Yopai Yopai commented Dec 31, 2019

Reference to allow_upscale has been removed from the main doc file (filters.rst), see jeffclemens@0eb167b

But this option is still present in the "Sizing filters" page.

| Branch? | as the commit above. I don't know if allow_upscale has been functional at one time
| Bug fix? | Documentation fix
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | not needed
| Fixed tickets | "As stated in #560, allow_upscale is no longer functional"

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this fix!

@dbu dbu merged commit 1b322e7 into liip:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants