Create "foo bar.jpeg.webp" #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The I didn't find any explicit reference, but I think the goal of this test is to ensure that when special chars/white spaces are used in the path, the cache is correctly resolved thus the cache is not re-build from source at every request. You should dump the cached file at the beginning of the test as done with the jpeg version. |
…ePathWithSpecialCharactersAndWhiteSpaces()
peter-gribanov
force-pushed
the
fix_test_resolve_path_with_spaces
branch
from
358f427
to
4da6d10
Compare
|
@fbourigault Yes. You were right. |
fbourigault
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
foo bar.jpeg.webpfor fixImagineControllerTest::testShouldResolvePathWithSpecialCharactersAndWhiteSpaces().See #1329 (comment)