Run PHP-CS-Fixer in GitHub Actions #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbourigault
force-pushed
the
github-actions-php-cs-fixer
branch
from
87fdb4d
to
3329715
Compare
fbourigault
force-pushed
the
github-actions-php-cs-fixer
branch
from
3329715
to
6ba43f3
Compare
fbourigault
force-pushed
the
github-actions-php-cs-fixer
branch
2 times, most recently
from
715ec85
to
1c65154
Compare
lsmith77
reviewed
Jan 5, 2021
| @@ -32,9 +32,7 @@ class ResolveCache implements \JsonSerializable | |||
| private $force; | |||
|
|
|||
| /** | |||
| * @param string $path | |||
There was a problem hiding this comment.
so the idea here is to only document parameters that are not fully documented via the method signature?
There was a problem hiding this comment.
This come from the @Symfony ruleset.
I could set no_superfluous_phpdoc_tags to false, revert changes and stick with the GitHub Actions part.
Then we could discuss of the rules to apply to this project.
|
I think its fine just wanted to understand.
On Tue, 5 Jan 2021 at 12:34, Fabien Bourigault ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Async/ResolveCache.php
<#1335 (comment)>
:
> @@ -32,9 +32,7 @@ class ResolveCache implements \JsonSerializable
private $force;
/**
- * @param string $path
This come from the @symfony ruleset.
I could set no_superfluous_phpdoc_tags to false, revert changes and stick
with the GitHub Actions part.
Then we could discuss of the rules to apply to this project.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1335 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACJJ56OZD3KHZUHGZMYYMTSYL2MVANCNFSM4VTR7BKA>
.
--
regards,
Lukas
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StyleCI builds report running in 0 files 🤷♂️
This move the execution of PHP-CS-Fixer in GitHub Actions and report CS violations using cs2pr.