fix handling of + in image names, added some functional tests #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Oct 5, 2021
| return implode('/', array_map('rawurlencode', explode('/', $path))); | ||
| } | ||
|
|
||
| public static function urlPathToFilePath(string $url): string | ||
| { | ||
| // used urldecode instead of rawurlencode for BC safety to support "+" in URL |
There was a problem hiding this comment.
this did the opposite of what was intended: if there is a + in the filename, we would end up with instead.
There was a problem hiding this comment.
no worries, it is quite confusing what is going on, and the encoding the the symfony route generator does is ... surprising.
i added some unit and functional tests to help us better understand what is happening.
Closed
dbu
force-pushed
the
fix-special-character-handling
branch
from
00dff13
to
749b712
Compare
dbu
force-pushed
the
fix-special-character-handling
branch
from
749b712
to
b91e217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some functional tests for handling of special characters, and fixing to not break for
+.