Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using "vips" driver #1495

Closed
wants to merge 1 commit into from
Closed

Conversation

PabloKowalczyk
Copy link
Contributor

@PabloKowalczyk PabloKowalczyk commented Dec 1, 2022

Q A
Branch? 2.x
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fix #1494
License MIT
Doc

@dbu
Copy link
Member

dbu commented Dec 1, 2022

for phpstan we should add imagine-vips to the require-dev section in composer. (we could also ignore the error, but i prefer adding it, so we notice if something goes off.)

@PabloKowalczyk
Copy link
Contributor Author

I've added rokka/imagine-vips to require-dev and to suggest also.

@dbu
Copy link
Member

dbu commented Dec 1, 2022

ah dang. we support older php than vips does. i will try something with the ci.

@PabloKowalczyk
Copy link
Contributor Author

ah dang. we support older php than vips does. i will try something with the ci.

PHP 7.1 is quite old https://www.php.net/supported-versions.php :)

@dbu dbu mentioned this pull request Dec 1, 2022
@dbu dbu closed this in #1496 Dec 1, 2022
@PabloKowalczyk PabloKowalczyk deleted the add-vips branch December 1, 2022 13:08
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 81.682% when pulling 31f67e8 on PabloKowalczyk:add-vips into ee15813 on liip:2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use vips driver
3 participants