[1.0][filter] Dynamic filters

[makasim]

This attempts to address #268. Other solutions\issues: #42, #271

Use cases:

• Twig:

{% set runtimeConfig = {"thumbnail": {"size": [50, 50] }} %}
<img src="{{ '/images/dream.jpg' | imagine_filter('thumbnail', runtimeConfig) }}" />

• Php:

<?php

$cacheManager->getBroserPath($path, $filter, array(
    'thumbnail' => array(
        'size' => array(50, 50),
    )
));

Here you can see filter url:

http://liip-imagine-sandbox.dev/appp.php/media/cache/thumbnail_web_path/images/dream.jpg?filters%5Bthumbnail%5D%5Bsize%5D%5B0%5D=50&filters%5Bthumbnail%5D%5Bsize%5D%5B1%5D=50&_hash=PkE1ct4QN1BJct6P6Pqfmb%2FelZ%2F99tFgZjsn29zTs8A%3D

and resolved one:

http://liip-imagine-sandbox.dev/media/cache/thumbnail_web_path/PkE1ct4Q/images/dream.jpg

The url contains PkE1ct4Q in path to not mess with pre configured filter caches. It is not possible to remove a single custom cache (at least you the whole path including PkE1ct4Q). but remove all has to work quite well.

[makasim]

Here I want to reused UriSigner from HttpKernel to check url was not modified

[makasim]

@havvg the logic is ready for review. I still have to fix some tests and add new

[makasim]

@havvg added tests, updated README.md. Ready for review

[makasim]

@havvg ping

[ASKozienko]

I dont like this place because it generates url of local controller

[makasim]

@ASKozienko I dont like it neither. In future it has to be optimized, for now I think we can start with simple solution and later change implementation.

[ASKozienko]

looks good in general

[makasim]

@havvg ping

[makasim]

@havvg ping

[makasim]

@havvg is not responding for some time. what should I do to proceed with my open PRs Any thoughts @lsmith77 @dbu?

I can wait for @havvg if I hear some words from him. Could I request a maintainer rights?

[havvg]

+1 on maintainer rights. I'm quite busy these days, and got some illness, too :(

[makasim]

@havvg oh you are here (:. I wish you get better very soon.

[lsmith77]

I have given @makasim commit rights.

[havvg]

Thanks!

[makasim]

@lsmith77 thanks, is there any policy I have to follow as a maintainer. just a few words about what I can and what I cannot (: to make things clear.

[antonbabenko]

Congratulations @makasim !

[havvg]

@makasim The only real policy right now: Keep the master branch stable (by following semver.org).
The develop branch is unstable, free for any re-factoring (as you/we did already). Please do not push any branches into this repository, as they will show up on packagist. Everything should be done using a PR.

Feel free to maintain :-)

[makasim]

@havvg thanks, will do

[makasim]

I am going to merge this tomorrow. (if tests pass ofcourse)

[trsteel88]

Will the use of this logic be added to the documentation soon?

[makasim]

@trsteel88 it is already there read README.md. Search for You can also pass some options at runtime:. In the controller you have to use CacheManager::getBrowserPath method.

[makasim]

@trsteel88 please note you have to read the doc of develop branch

[trsteel88]

Thanks @makasim.

I just wanted to raise 1 issue with this implementation. Currently, you are generating a hash to authenticate that the values are correct. I think this should be split into several "directories".

Eg, say the generated hash is "S8rrlhhQ" I think it should be split up so it becomes "S8r/rlh/hQ" (or something similar). Otherwise, if a website has 100,000 images it is going to create up to 100,000 folders inside 1 (or more) directories. Splitting it into several directories will scatter the structure a bit more. This will make it much easier to navigate through ftp or viewing the folder and doing "ls -la".

[makasim]

@trsteel88 Good point. I've created an issue #341

[trsteel88]

Should the $params be sorted alphabetically (by key)?

Eg, say your dynamic filter is {width: 100, height: 200, extra: {'key': 'val'}}

If I then generate a image using {height: 200, width: 100, extra: {'key': 'val'}} it will generate a different hash.

I think that these parameters should be sorted to try and minimise duplicate image generation. Obviously the params would need to cascade incase their are multiple array within the config.

Thoughts?

[makasim]

that's a good idea, you could create an issue so we dont forget about it,