add GaufretteFilesystemLoader #63

havvg · 2012-04-04T17:04:18Z

Example service definitions (using the FilesystemMap of KnpGaufretteBundle):

services:
    gaufrette.filesystem.profile_photos:
        class: Gaufrette\Filesystem
        factory_service: 'knp_gaufrette.filesystem_map'
        factory_method: 'get'
        arguments:
            - 'profile_photos'

    liip_imagine.data.loader.gaufrette.profile_photos:
        class: "%liip_imagine.data.loader.gaufrette.class%"
        arguments:
            - "@liip_imagine"
            - "@gaufrette.filesystem.profile_photos"
        tags:
            - { name: 'liip_imagine.data.loader', loader: 'gaufrette.profile_photos' }

Example filter set:

liip_imagine:
    filter_sets:
        profile_photo:
            data_loader: 'gaufrette.profile_photos'
            filters:
                thumbnail: { size: [300, 300], mode: outbound }

stof · 2012-04-04T17:36:50Z

I'm wondering whether this loader is needed or if we should implement a StreamLoader able to load from any stream instead. In this case, we could use Gaufrette (as it provides a stream wrapper) but also other streams.

lsmith77 · 2012-04-11T18:37:37Z

@stof not sure what you mean exactly.

@havvg this PR definitely also needs an update to the README, though I guess first lets see what @stof was talking about.

stof · 2012-04-11T21:49:38Z

@lsmith77 This PR adds a loader expecting the Gaufrette class to access files handled by Gaufrette. But it could use a far more generic solution if it was adding a loader able to load from a stream instead (any stream, not only the local filesystem). Gaufrette has a great feature: it implements a stream wrapper, meaning than any library expecting to open a stream would be able to open a file hidden behind Gaufrette (and so located anywhere) withoutt needing to know about Gaufrette. For instance, you can ask AsseticBundle to dump to your remote server handled by Gaufrette by using gaufrette://foobar/ as write_to path (there used to be an issue with S3 a while ago. Dunno if it has been fixed as I stopped stoffing Gaufrette a few months ago because of missing time)

lsmith77 · 2012-04-12T09:52:47Z

ok .. that sounds indeed like the better approach .. @havvg what do you think?

havvg · 2012-04-14T19:20:12Z

Hey there, sorry for the delay, I was on vacations.

The generalization sounds good to me, can't promise any ETA by now, but will look into it.

havvg · 2012-04-18T16:25:32Z

An example configuration to use the StreamLoader:

services:
    liip_imagine.data.loader.stream.profile_photos:
        class: "%liip_imagine.data.loader.stream.class%"
        arguments:
            - "@liip_imagine"
            - 'gaufrette://profile_photos/'
        tags:
            - { name: 'liip_imagine.data.loader', loader: 'stream.profile_photos' }

By adding some kind of factory, one could also inject an active stream context as third parameter.

stof · 2012-04-18T20:20:29Z

Imagine/Data/Loader/StreamLoader.php

+         * The error suppressing is solely to determ whether the file exists.
+         * file_exists() is not used as not all wrappers support stat() to actually check for existing resources.
+         */
+        if (($this->context and @!fopen($name, 'r', null, $this->context)) || @!fopen($name, 'r')) {


please use && instead of and

btw, you should close the stream you just opened to avoid keeping an eventual lock

lsmith77 · 2012-04-19T07:48:54Z

can you add your example config to the README?

stof · 2012-04-19T10:37:24Z

Imagine/Data/Loader/StreamLoader.php

+     * @param string $wrapperPrefix
+     * @param \resource|null $context
+     */
+    public function __construct(ImagineInterface $imagine, $wrapperPrefix, \resource $context = null)


Can you really typehint a resource ?

Oops, no you can't, fixed.

lsmith77 · 2012-04-19T13:48:50Z

README.md

+The `Liip\ImagineBundle\Imagine\Data\Loader\StreamLoader` allows to read images from any stream registered
+thus allowing you to serve your images from literally anywhere.
+
+The example service definition shows how to use a stream wrapped by the [Gaufrette](https://github.com/KnpLabs/Gaufrette) filesystem abstraction layer.


it would be good to clarify that this means one has to register the gaufrette stream wrapper for this to work.

add GaufretteFilesystemLoader

neilferreira · 2012-05-02T04:03:44Z

Hey guys,

I'm trying to use the Streamloder you've just setup, which looks to be pretty good based of what it should be capable of. What I'm getting stuck with at the moment is the following,

inside the Gaufrette readme example it shows that you've got to call 'StreamWrapper::register' manually to register the actual streamwrapper, at which point and where exactly do I need to register my actual stream? Do you have any real life examples of where you've used the StreamLoader for your profile images?

Where in your codebase do have you registered your profile_photos stream, and what type of filesystem are you using for it to dump the contents of that stream to so the StreamLoader can read from it?

Cheers.

stof · 2012-05-02T07:06:17Z

I would register the Gaufrette wrapper in the boot method of a bundle so that it is done before the runtime logic

neilferreira · 2012-05-02T07:10:04Z

Hey,

I wasn't aware that method exists, but makes sense. I'm still eagler to know if @havvg has any further examples to share around.

Cheers

lsmith77 · 2012-05-02T07:27:01Z

either way .. we should expand the read me to cover this question

havvg · 2012-05-02T08:57:44Z

Hi there,

I created a gist how I solved this problem.
It's using dependency injection with tagged services to register the stream to be wrapped.

@neilferreira We are storing the images on Amazon S3, originals, cropped and cached (using AmazonS3Resolver from #66)

neilferreira · 2012-05-02T09:50:26Z

Hey,

Thanks for the gist, my next task after getting the StreamLoader working was to do exactly what you've done, storing originals and cropped copies of the images on AmazonS3, feel free to post some more gist's of the rest of your setup :)

Do you have functionality you've been using inside https://github.com/Ormigo/LiipImagineBundle ? Or have you merged all of your changes into the Liip Imagine bundle master via PRs.

Cheers

havvg · 2012-05-02T10:02:08Z

The fork only contains the #66 PR, no other diff beside that, we are on the respective feature branch.
The README of this PR contains how we set up the services.

The PR also adds a remove method to the CacheManager to be able to remove the respective files, it the user uploads a new version of his profile photo.

skigun · 2012-10-12T15:01:51Z

Hi there,

I recently send a PR in a KnpGaufretteBundle KnpLabs/KnpGaufretteBundle#23
Now the stream wrapper can be registered and configured globally in KnpGaufretteBundle

lsmith77 · 2012-10-12T15:08:26Z

can you send a PR to make the necessary adjustments?

KeKs0r · 2013-07-03T02:48:09Z

I really would like to see a full example how this is used. I tried to create an streamwrapper in gaufrette for Amazon S3 and then use it with this bundle. The result for the filtered file is something like this:

http://localhost/tipp/web/app_dev.php/media/cache/profile_thumb_small/gaufrette://profile_fs/51d37d420eab4.png

I also setup the cacheresolver for S3: https://github.com/liip/LiipImagineBundle/blob/master/Resources/doc/cache-resolver/amazons3.md

Somehow I just dont get images from S3 working. (I would like to also store the cached images on S3)

add GaufretteFilesystemLoader

ba7c2dc

add StreamLoader

cb38837

stof reviewed Apr 18, 2012
View reviewed changes

havvg added 2 commits April 19, 2012 10:28

close stream to avoid lock, code clean-up

b95de65

add section about StreamLoader to README

848ffab

stof reviewed Apr 19, 2012
View reviewed changes

remove resource type hint

2c18c55

lsmith77 reviewed Apr 19, 2012
View reviewed changes

clarify StreamLoader requires registered wrapper

3a66d4d

lsmith77 added a commit that referenced this pull request Apr 22, 2012

Merge pull request #63 from havvg/feature/gaufrette-loader

dfed61a

add GaufretteFilesystemLoader

lsmith77 merged commit dfed61a into liip:master Apr 22, 2012

This was referenced Apr 22, 2012

Issue #56 - Added an Amazon S3 resolver #60

Closed

Ability to serve images from database or s3? #56

Closed

havvg mentioned this pull request Oct 30, 2012

add info on the StreamWrapper of GaufretteBundle #115

Merged

havvg deleted the feature/gaufrette-loader branch February 8, 2013 15:41

havvg mentioned this pull request May 15, 2013

Grab external image, generate thumbnail and use it on website #187

Closed

KeKs0r mentioned this pull request Jul 8, 2013

Complete S3 Setup: Original Images and cached Images on AWS S3 #203

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add GaufretteFilesystemLoader #63

add GaufretteFilesystemLoader #63

havvg commented Apr 4, 2012

stof commented Apr 4, 2012

lsmith77 commented Apr 11, 2012

stof commented Apr 11, 2012

lsmith77 commented Apr 12, 2012

havvg commented Apr 14, 2012

havvg commented Apr 18, 2012

stof Apr 18, 2012

stof Apr 18, 2012

lsmith77 commented Apr 19, 2012

stof Apr 19, 2012

havvg Apr 19, 2012

lsmith77 Apr 19, 2012

neilferreira commented May 2, 2012

stof commented May 2, 2012

neilferreira commented May 2, 2012

lsmith77 commented May 2, 2012

havvg commented May 2, 2012

neilferreira commented May 2, 2012

havvg commented May 2, 2012

skigun commented Oct 12, 2012

lsmith77 commented Oct 12, 2012

KeKs0r commented Jul 3, 2013

add GaufretteFilesystemLoader #63

add GaufretteFilesystemLoader #63

Conversation

havvg commented Apr 4, 2012

stof commented Apr 4, 2012

lsmith77 commented Apr 11, 2012

stof commented Apr 11, 2012

lsmith77 commented Apr 12, 2012

havvg commented Apr 14, 2012

havvg commented Apr 18, 2012

stof Apr 18, 2012

Choose a reason for hiding this comment

stof Apr 18, 2012

Choose a reason for hiding this comment

lsmith77 commented Apr 19, 2012

stof Apr 19, 2012

Choose a reason for hiding this comment

havvg Apr 19, 2012

Choose a reason for hiding this comment

lsmith77 Apr 19, 2012

Choose a reason for hiding this comment

neilferreira commented May 2, 2012

stof commented May 2, 2012

neilferreira commented May 2, 2012

lsmith77 commented May 2, 2012

havvg commented May 2, 2012

neilferreira commented May 2, 2012

havvg commented May 2, 2012

skigun commented Oct 12, 2012

lsmith77 commented Oct 12, 2012

KeKs0r commented Jul 3, 2013