Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Composer Update Notice Hook #853

Closed

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented Jan 15, 2017

This is a composer update/install hook that reads in the UPGRADE.md file, searches for a header matching the version Composer is installing, and, if such a version exists in the file, prints out the corresponding text for the user to acknowledge. See #846 (comment) for the comments where the discussion for this component began.

Here is an example of the output

liip-imagine-composer-update-notice

Lastly, it is important to note that I cut off support for PHP 5.3; users using this release will simply not see any notices (it doesn't error out or anything, it is just turned off for them). This helps facilitate a sane, well-laid-out code base (PHP 5.3 doesn't properly implement closure scope).

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jan 15, 2017
@robfrawley robfrawley force-pushed the feature-composer-upgrade-notice branch 5 times, most recently from c2965f7 to 2c22f2e Compare January 15, 2017 07:13
@robfrawley robfrawley self-assigned this Jan 15, 2017
@robfrawley robfrawley added Type: Documentation This item pertains to documentation of this project. Level: New Feature 🆕 This item involves the introduction of new functionality. labels Jan 15, 2017
@robfrawley robfrawley added this to the v1.7.1 milestone Jan 15, 2017
@robfrawley robfrawley force-pushed the feature-composer-upgrade-notice branch from 2c22f2e to 0e3d437 Compare January 15, 2017 07:41
@robfrawley
Copy link
Collaborator Author

robfrawley commented Jan 15, 2017

Nevermind; only root scripts are called. ;-(

@robfrawley robfrawley closed this Jan 15, 2017
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality. Type: Documentation This item pertains to documentation of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants