Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] Add Hithub templates for issues and PRs #863

Merged
merged 1 commit into from Jan 27, 2017

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented Jan 27, 2017

Q A
Branch? 1.0
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? n/a
Fixed tickets #859
License MIT
Doc PR

Thanks to @cedricziel, we now know Github issue and PR templates can be added via file, instead of relying on the Github settings pages. Do @antoligy or @cedricziel have any alterations to these templates they'd suggest?

@robfrawley robfrawley self-assigned this Jan 27, 2017
@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jan 27, 2017
@cedricziel
Copy link
Collaborator

No objections towards the templates themselves. Can we ignore them when exporting?

.gitattributes:

.github/issue_template.md export-ignore
.github/pull_request_template.md export-ignore

Maybe we should ignore some of the other meta-files as well.

@robfrawley
Copy link
Collaborator Author

@cedricziel Added

@cedricziel
Copy link
Collaborator

Great, thx!

Fine for me.

@alexwilson
Copy link
Collaborator

alexwilson commented Jan 27, 2017

Truth be told I'm not sure we'll know how well this helps us until we start using it, so no objections from me!

@robfrawley robfrawley merged commit 4cef6ce into liip:1.0 Jan 27, 2017
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jan 27, 2017
@robfrawley robfrawley deleted the feature-github-templates branch January 28, 2017 05:32
@robfrawley robfrawley changed the title Add github issue and pr templates [GitHub] Add github issue and pr templates Feb 7, 2017
@robfrawley robfrawley changed the title [GitHub] Add github issue and pr templates [GitHub] Add Hithub templates for issues and PRs Feb 7, 2017
@robfrawley robfrawley mentioned this pull request Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants