Add flip filter implementation to core #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
added
the
State: Reviewing
robfrawley
added
Type: Documentation
cedricziel
approved these changes
May 2, 2017
|
Thx for taking the time to implement this! :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a simple filter implementation to allow for image flipping (both along the
xandyaxis). Included are tests and documentation, as well as some general cleanup of theREADME.mdfile.The included
OptionsResolverabstraction was introduced to aid in the API differences between Symfony=2.3and>=2.7. My long-term intention is to move other filter loader implementations to using the options resolver as well; once this has been done, this abstraction can be removed in the2.xbranch where it is no longer required without affecting the method calls within filters.