[Composer] Allow imagine-library version 0.7.0 #958
Conversation
robfrawley
added
Level: Bug 🐞
| @@ -19,7 +19,7 @@ | |||
| }, | |||
| "require": { | |||
| "php": "^5.3.9|^7.0", | |||
| "imagine/Imagine": "^0.6.3,<0.7", | |||
| "imagine/Imagine": "^0.6.3|^0.7.0,<0.8", | |||
There was a problem hiding this comment.
The ,<0.8 is not necessary. ^0.7.0 means >=0.7.0 <0.8.0.
There was a problem hiding this comment.
I realize; I believe the current syntax was used to provide clarity, as even before the change when it was ^0.6.3,<0.7, the <0.7 was unnecessary. It's important to note that the rule you mentioned only applies for fully enumerated versions [above 1.x], so it may be a good idea to retain the upper constraint so when someone comes along and changes it to, say ^1.0, we don't open the floodgates.
There are a bunch of ways to write this, such as ^0.6.3|^0.7.0,<0.8, >=0.6.3,~0.6,<0.8, >=0.6.3,<0.8 or ~0.6.3|~0.7.0 (the latter of which I personally prefer), but the original intention seems to have been verbosity, which the current syntax provides, no?
If anything, I'd prefer ~0.6.3|~0.7.0, honestly.
There was a problem hiding this comment.
^0.7 and ^0.7.0 are actually equivalent. But I understand your point. It is more clear for those who don't know how the the caret operator works.
There was a problem hiding this comment.
It's important to note that the rule you mentioned only applies for fully enumerated versions
I meant to append that with "above 1.x" and I obviously used the wrong example of 0.7 where I intended to use 1.0. Was typing quickly. ;-)
robfrawley
changed the title
robfrawley
changed the title
robfrawley
changed the title
|
I guess to avoid any complaints on bumping most from .6 to .7, we potentially release under a minor version? Either way 👍 |
|
@robfrawley can you tag a version for this please? |
|
The next release (which will be tagged as You can reference the 1.9.0 milestone to track progress. With any luck, that date won't slip; with some luck, that date may be moved up. We'll see. :-) |
|
Any chance we can get this tagged sooner as a patch version @robfrawley? It's my understanding that bug fixes can/should be tagged straight away? e.g 1.8.1 Just to be a pain, we've just got this issue occurring on a number of sites where we have to manually edit the file on the server :( |
|
@trsteel88 See #983. As for quick releases (even for bugs and other issues), the lax schedule is the result of the minimum time available to only three "sporadically active" maintainers. We try our best. :-) |
|
Thank you. Appreciate the quick response. |
|
@trsteel88 As for fixes, you can use your own bugfixes by adding your fork as composer repository (https://getcomposer.org/doc/05-repositories.md#vcs) and require version |
|
@trsteel88 The |
|
Thanks @robfrawley Good to know @cedricziel |
This pull request adds the ability to utalize version
0.7.0of the Imagine Library, and raises our upper limit constraint to0.8.0. By default, this will actually cause most people to upgrade from0.6.0to0.7.0of Imagine Library, but it allows those who explicitly constrain their project to Imagine Library0.6.0to remain on that version, as well. It provides a cleaner, alternate approach to #935 with passing tests. Fixes an important issue introduced by3.4.3of theimagickextension; see php-imagine/Imagine#547.