[2.x] Remove FixturesTrait #26

alexislefebvre · 2019-07-08T23:42:49Z

See #18

TODO:

check that all the documentation is up-to-date

scaytrase · 2019-08-05T07:17:36Z

#25 is done. any other show-stoppers?

alexislefebvre · 2019-08-05T07:44:16Z

I have to fix the tests.

zalas/phpunit-injector requires PHP 7.2+, so we need a solution to keep PHP 7.1 support with tests.

scaytrase · 2019-08-05T08:12:44Z

PHP 7.1 living out its days with security fixes only now. EOL is on Dec 2019. Is it really worth to support?

alexislefebvre · 2019-08-05T09:26:03Z

It may fix the performance issue reported in #12

doc/database.md

alexislefebvre · 2019-11-05T15:11:19Z

Upgrade guide is missing.

src/Services/DatabaseTools/ORMSqliteDatabaseTool.php

alexislefebvre · 2019-11-13T23:44:27Z

Using zalas/phpunit-injector requires 2 new class dependencies, 2 new properties and their declaration.

Maybe we could keep the FixturesTrait in ordet to factorize this code.

doc/database.md

src/Resources/config/database_tools.xml

lsmith77 · 2021-03-04T19:18:28Z

src/Services/DatabaseBackup/MysqlDatabaseBackup.php


        $executor->getReferenceRepository()->save($this->getBackupFilePath());
        self::$metadata = $em->getMetadataFactory()->getLoadedMetadata();

-        exec("mysqldump --host {$dbHost} {$port} {$dbPass} --user {$dbUser} --no-create-info --skip-triggers --no-create-db --no-tablespaces --compact {$dbName} > {$this->getBackupFilePath()}");
+        exec("{$dbPass} mysqldump --host {$dbHost} {$port} --user {$dbUser} --no-create-info --skip-triggers --no-create-db --no-tablespaces --compact {$dbName} > {$this->getBackupFilePath()}");


was this intentional?

Yes the password is passed as an environment variable to avoid a warning from mysqldump.

lsmith77 · 2021-03-04T19:19:35Z

src/Services/DatabaseTools/MongoDBDatabaseTool.php

@@ -77,12 +77,10 @@ public function loadFixtures(array $classNames = [], bool $append = false): Abst
        if ($backupService) {
            $event = new ReferenceSaveEvent($this->om, $executor, $backupService->getBackupFilePath());
            $this->eventDispatcher->dispatch($event, LiipTestFixturesEvents::PRE_REFERENCE_SAVE);
-            $this->testCase->preReferenceSave($this->om, $executor, $backupService->getBackupFilePath());


is this already documented in the upgrading guide?

Yes but not in details: https://github.com/liip/LiipTestFixturesBundle/blob/0006751a3f32ce0b56af9638d0d17304416a02c2/CHANGELOG.md#2x0-tba

Done in #105

lsmith77 · 2021-03-04T19:20:54Z

tests/Test/ConfigEventsTest.php

        $eventDispatcher->addListener(
            $eventName,
            [$mock, $methodName]
        );

        // By loading fixtures, the events will be called (or not)
-        $fixtures = $this->loadFixtures([]);
+        if ($withCache) {


just FYI .. in such an if/else situation with single line assignments to the same variable, I personally prefer a ternary for readability. but I have no intention of enforcing such a personal preference

lsmith77

I just read over the PR, I think overall this looks awesome. I will also ask for feedback via twitter

alexislefebvre · 2021-03-07T16:26:50Z

Thanks for the review. I updated the documentation.

I will add events to the upgrade guide later. And update the services to use classes names too, right now it breaks the tests and I don't understand why.

alexislefebvre changed the title ~~Remove get container~~ [WIP] Deprecate FixturesTrait Jul 8, 2019

alexislefebvre force-pushed the remove-getContainer branch from 3765580 to c0c3fe3 Compare July 28, 2019 22:27

alexislefebvre force-pushed the remove-getContainer branch from c0c3fe3 to 78a0688 Compare September 6, 2019 23:24

rvanlaak mentioned this pull request Oct 30, 2019

Remove FixturesTrait dependency on environment #44

Merged

alexislefebvre commented Nov 5, 2019

View reviewed changes

doc/database.md Show resolved Hide resolved

alexislefebvre self-assigned this Nov 8, 2019

alexislefebvre force-pushed the remove-getContainer branch from 78a0688 to 6d5f586 Compare November 8, 2019 00:43

alexislefebvre commented Nov 8, 2019

View reviewed changes

src/Services/DatabaseTools/ORMSqliteDatabaseTool.php Outdated Show resolved Hide resolved

alexislefebvre force-pushed the remove-getContainer branch from 2803d51 to 14e978e Compare November 13, 2019 23:36

alexislefebvre commented Nov 14, 2019

View reviewed changes

doc/database.md Outdated Show resolved Hide resolved

alexislefebvre force-pushed the remove-getContainer branch from fb0dcb9 to dab392c Compare June 21, 2020 15:37

alexislefebvre mentioned this pull request Jun 21, 2020

Upgrade to 1.8/1.9.1 creates Kernel boot error #66

Closed

alexislefebvre added 11 commits December 9, 2020 19:37

Deprecate FixturesTrait

f6a6210

Require PHP 7.2 and Symfony 3.4 or 4.3

9717001

Remove duplicated line

a64c6a2

Use DoctrinePHPCRBundle only if it exists

fd88a85

Check that methods exist before calling them

9f8bd16

Remove FixturesTrait

b963e74

Update documentation

5ae316f

Update documentation

5ffa5ea

Remove deprecation of FixturesTrait

0df4234

Remove deprecation of FixturesTrait

a44309e

Cleanup

6b32011

alexislefebvre force-pushed the remove-getContainer branch from dab392c to 6b32011 Compare December 9, 2020 18:38

alexislefebvre commented Feb 24, 2021

View reviewed changes

doc/database.md Outdated Show resolved Hide resolved

alexislefebvre commented Feb 24, 2021

View reviewed changes

doc/database.md Outdated Show resolved Hide resolved

alexislefebvre force-pushed the remove-getContainer branch from 87d77d9 to 97a4444 Compare February 24, 2021 22:18

Changing the registry on the fly didn't work, revert the changes

f7e3e54

alexislefebvre force-pushed the remove-getContainer branch from 97a4444 to f7e3e54 Compare February 24, 2021 22:26

alexislefebvre added 2 commits February 26, 2021 21:41

Merge branch '2.x' into remove-getContainer

5444ef7

Update documentation

dde98be

alexislefebvre added the help wanted Extra attention is needed label Mar 3, 2021

alexislefebvre marked this pull request as ready for review March 3, 2021 21:53

lsmith77 reviewed Mar 4, 2021

View reviewed changes

doc/database.md Outdated Show resolved Hide resolved

lsmith77 reviewed Mar 4, 2021

View reviewed changes

src/Resources/config/database_tools.xml Show resolved Hide resolved

lsmith77 reviewed Mar 4, 2021

View reviewed changes

alexislefebvre force-pushed the remove-getContainer branch 4 times, most recently from d1db9ed to 328a74a Compare March 7, 2021 16:12

Update documentation

bea8371

alexislefebvre force-pushed the remove-getContainer branch from 328a74a to bea8371 Compare March 7, 2021 16:15

alexislefebvre merged commit 4104bb7 into 2.x Mar 7, 2021

alexislefebvre deleted the remove-getContainer branch March 7, 2021 16:28

This was referenced Mar 7, 2021

2.x: Remove services ids #104

Merged

2.x: Update the upgrade documentation #105

Merged

[2.0] Refactoring loadFixtures #87

Closed

mbabker mentioned this pull request Apr 27, 2021

Fatal Error with Symfony 5.3 #112

Closed

alexislefebvre mentioned this pull request May 31, 2021

Error with definition of method getContainer and Symfony 5.3 liip/LiipFunctionalTestBundle#583

Closed

alexislefebvre mentioned this pull request Jan 7, 2022

[3.x] WebTestCase and FixturesTrait override (?) liip/LiipFunctionalTestBundle#535

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2.x] Remove FixturesTrait #26

[2.x] Remove FixturesTrait #26

alexislefebvre commented Jul 8, 2019 •

edited

Loading

scaytrase commented Aug 5, 2019

alexislefebvre commented Aug 5, 2019

scaytrase commented Aug 5, 2019

alexislefebvre commented Aug 5, 2019

alexislefebvre commented Nov 5, 2019

alexislefebvre commented Nov 13, 2019

lsmith77 Mar 4, 2021

alexislefebvre Mar 7, 2021

lsmith77 Mar 4, 2021

alexislefebvre Mar 7, 2021

alexislefebvre Mar 7, 2021

lsmith77 Mar 4, 2021

lsmith77 left a comment

alexislefebvre commented Mar 7, 2021 •

edited

Loading

[2.x] Remove FixturesTrait #26

[2.x] Remove FixturesTrait #26

Conversation

alexislefebvre commented Jul 8, 2019 • edited Loading

scaytrase commented Aug 5, 2019

alexislefebvre commented Aug 5, 2019

scaytrase commented Aug 5, 2019

alexislefebvre commented Aug 5, 2019

alexislefebvre commented Nov 5, 2019

alexislefebvre commented Nov 13, 2019

lsmith77 Mar 4, 2021

Choose a reason for hiding this comment

alexislefebvre Mar 7, 2021

Choose a reason for hiding this comment

lsmith77 Mar 4, 2021

Choose a reason for hiding this comment

alexislefebvre Mar 7, 2021

Choose a reason for hiding this comment

alexislefebvre Mar 7, 2021

Choose a reason for hiding this comment

lsmith77 Mar 4, 2021

Choose a reason for hiding this comment

lsmith77 left a comment

Choose a reason for hiding this comment

alexislefebvre commented Mar 7, 2021 • edited Loading

alexislefebvre commented Jul 8, 2019 •

edited

Loading

alexislefebvre commented Mar 7, 2021 •

edited

Loading