feat: fix dbal deprecation for connection

[Chris53897]

#259

This fix does makes it possible, to use it with my bundle and orm3 dbal4
I got a NotSupported Exception with SQLite-Database.

Please have a look if changes are correct.

[alexislefebvre]

Could you please explain the try … catch block?

If the goal is to call createSchemaManager when it's available and fallback to getSchemaManager, I suggest to use a BC approach:

LiipTestFixturesBundle/src/Services/DatabaseTools/ORMDatabaseTool.php

Lines 205 to 209 in 243e9ae

	if (method_exists($this->connection, 'fetchColumn')) {
	$currentValue = $this->connection->fetchColumn('SELECT @@SESSION.foreign_key_checks');
	} else {
	$currentValue = $this->connection->fetchOne('SELECT @@SESSION.foreign_key_checks');
	}

[Chris53897]

If i run it in my bundle for testing. I got a NotSupported Exception with SQLite-Database.
The try … catch block solves this.

@mbabker Can you please check if my changes are correct?

[alexislefebvre]

Thanks for the explanation.

I suggest to add a rule to ignore this call when the connection is a SQLite one. So it won't need a try … catch block.

[mbabker]

I suggest to add a rule to ignore this call when the connection is a SQLite one. So it won't need a try … catch block.

Based on https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-sqliteschemamanagercreatedatabase-and-dropdatabase-methods I'd say the try/catch might actually be more appropriate while DBAL 3.x is supported. As the functionality is only removed from 4.0, it avoids getting into deeper instanceof checks plus some other check to work out the active DBAL version. Whereas the instanceof check would immediately turn this feature off for all SQLite users no matter the DBAL version.

[alexislefebvre]

Thanks you all for the PR and comments, here is a new release with these changes: https://github.com/liip/LiipTestFixturesBundle/releases/tag/2.7.3

[Chris53897]

thank you @alexislefebvre @mbabker