remove redundant builds, use twig 2.4 for lower bound test #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@stof wdyt? |
|
@stof, could you give some feedback on this PR? It's important for me, cause it blocks #198 (comment) |
stof
reviewed
Jun 18, 2019
.travis.yml
Outdated
| - php: 7.3 | ||
| env: SYMFONY_VERSION=@dev;ASSETIC=skip | ||
| - php: 7.0 | ||
| env: TWIG_VERSION=2.7.* | ||
| - php: 7.1 | ||
| env: SYMFONY_VERSION=3.0.*;TWIG_VERSION=2.4.* |
There was a problem hiding this comment.
why forcing to use the unmaintained 3.0 version of Symfony ?
There was a problem hiding this comment.
because its the lower bound in the composer.json
lsmith77
force-pushed
the
cleanup-travis
branch
3 times, most recently
from
94c632d
to
d51c13f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.