fix: should not call onAudioListsPanelChange if panel is closed when …

…hide panel
lijinke666 · Sep 19, 2020 · ade1774 · ade1774
1 parent 52ba3ae
commit ade1774
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/__tests__/tests/player.test.js b/__tests__/tests/player.test.js
@@ -1478,4 +1478,21 @@ describe('<ReactJkMusicPlayer/>', () => {
     wrapper.instance().onAudioCanPlay()
     expect(onAudioPlay).toHaveBeenCalled()
   })
+
+  it('should not call onAudioListsPanelChange if panel is closed when hide panel', () => {
+    const onAudioListsPanelChange = jest.fn()
+    const wrapper = mount(
+      <ReactJkMusicPlayer
+        audioLists={[
+          { musicSrc: 'aaa', name: 'aaa' },
+          { musicSrc: 'ddd', name: 'ddd' },
+        ]}
+        mode="full"
+        onAudioListsPanelChange={onAudioListsPanelChange}
+      />,
+    )
+
+    wrapper.find('.hide-panel').simulate('click')
+    expect(onAudioListsPanelChange).not.toHaveBeenCalled()
+  })
 })
diff --git a/src/index.js b/src/index.js
@@ -6,7 +6,6 @@
  */
 
 // FIXME: quietUpdate 更新之后 不能点击播放列表里的其他歌曲
-// FIXME: audio lists panel visible 收起时会调用
 import cls from 'classnames'
 import download from 'downloadjs'
 import getIsMobile from 'is-mobile'
@@ -917,9 +916,12 @@ export default class ReactJkMusicPlayer extends PureComponent {
   }
 
   _closeAudioListsPanel = () => {
+    const { audioListsPanelVisible } = this.state
     this.setState({ audioListsPanelVisible: false })
-    this.props.onAudioListsPanelChange &&
-      this.props.onAudioListsPanelChange(false)
+    if (audioListsPanelVisible) {
+      this.props.onAudioListsPanelChange &&
+        this.props.onAudioListsPanelChange(false)
+    }
   }
 
   themeChange = (isLight) => {